fix: round-2 loop-A fresh review (503c326 baseline) — B1 replay cap, A6 discount record, 2FA reissue+cooldown, notification flood, lockout saturation, VAT/refund-status consolidation
Round 2 Loop A fresh money/security/dup-mod review. 23 findings fixed: MONEY: - CRITICAL: B1 duplicate auto-refund gains an attempt cap (b1_attempts col, cap 3) — a rejected auto-refund no longer re-replays the expired key every sweep run (which minted a stacking unauthorized charge each time); FAILED-webhook demotion respects the cap; never re-replay a key whose B1 refund failed - HIGH: A6 deposit_covered_by_discount skip path now APPLIES the eligible campaign discount rows immediately (capped) instead of skipping with no discount recorded — no more promised-discount-not-recorded overcharge - MEDIUM: 2FA code burned by the SAVE gate is re-issued on failed new-card+save_card charges (re-issue guard now covers req.SaveCard) - LOW: GetBookingPaymentSummary excludes tip rows from paidAmount (remaining now matches the authoritative tip-excluded balance) SECURITY: - MEDIUM: unacknowledged CRITICAL admin-notification flood capped (global cap on critical_payment_log + refresh_token_reuse rows) - MEDIUM: 2FA reissue no longer bypasses the mint cooldown (Check no longer clears LastMintAt on gate-verify; cleared on terminal charge success) - MEDIUM: twofa.StateFor map-saturation returns a shared permanently-locked state instead of a fresh 5-guess budget per request - MEDIUM: ProgressiveRateLimit rejects 429 past maxProgressiveSleepDelayMs instead of sleeping unboundedly; login bcrypt concurrency semaphore added - LOW: loginInProgress 409->429; webhook key-set/URL-unset startup check; email-verification per-user attempt counter DUP/MOD: - formatCurrency single source (frontend format.ts, 7 files consolidated); SquareRefundStatusToLocal single source (errors.go, all sites); admin audit-log helper dedup; SCA retry model unified (proactive on all 6 surfaces); buyDailyTotal/daily-cap mirror via backend; lock TTL from backend; generateUUID at all card-form sites; magic numbers named (defaultPostgresHost, epsilon, fee constants); admin CASH + gift-card terminal charges now audited; DAV_SKIP_INIT documented in manuals Verified: 26/26 dev + 24/24 prod (GO_TESTING=1, the CI condition), both vet tags, frontend tests+build, env-docs 42/42.
This commit is contained in:
@@ -81,6 +81,27 @@ export function calculateAge(dateOfBirth: string | undefined | null): number | n
|
||||
return age;
|
||||
}
|
||||
|
||||
// Single cached GBP formatter shared by every `formatCurrency` call — one
|
||||
// `Intl.NumberFormat` instance instead of a fresh allocation per call, since
|
||||
// currency formatting runs on the app's hottest rendering paths. The explicit
|
||||
// `minimumFractionDigits: 2` guarantees whole pounds render as "£5.00", never
|
||||
// "£5". `formatCurrency` takes the amount in POUNDS (not pence).
|
||||
const gbpFormatter = new Intl.NumberFormat('en-GB', {
|
||||
style: 'currency',
|
||||
currency: 'GBP',
|
||||
minimumFractionDigits: 2
|
||||
});
|
||||
|
||||
/**
|
||||
* Format a monetary amount as GBP, e.g. 19.5 → "£19.50".
|
||||
*
|
||||
* The amount must be in POUNDS (e.g. `booking.total_amount`, `subtotal`).
|
||||
* For pence values, divide by 100 at the call site: `formatCurrency(pence / 100)`.
|
||||
*/
|
||||
export function formatCurrency(amount: number): string {
|
||||
return gbpFormatter.format(amount);
|
||||
}
|
||||
|
||||
/**
|
||||
* Create an array of numbers from 0 to n-1.
|
||||
*
|
||||
|
||||
Reference in New Issue
Block a user