popertots/Crussell
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(internal): replace log.Fatal with panic, add timezone to DSN, add empty S3 bucket check

Browse Source 
Replace log.Fatal in dev service init with panic for consistency. Add timezone=UTC to DAV connection DSN. Add IsEmpty() check for S3 dev bucket.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This commit is contained in:
popertots
2026-06-24 23:43:14 +01:00
co-authored by Sisyphus
parent e95b1a65af
commit 58996c553a
7 changed files with 136 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/internal/square/square_dev.go
+14 -8
View File
@@ -4,6 +4,7 @@
package square
import (
"crussell/clock"
"context"
"fmt"
"log"
@@ -85,7 +86,7 @@ func (m *MockClient) CreatePayment(ctx context.Context, req CreatePaymentReq) (*
m.mu.Lock()
defer m.mu.Unlock()
paymentID := fmt.Sprintf("pay_mock_%d", time.Now().UnixNano())
paymentID := fmt.Sprintf("pay_mock_%d", clock.Now().UnixNano())
fees := req.Amount*14/1000 + 25 // online rate: 1.4% + 25p
result := &PaymentResult{
@@ -107,7 +108,7 @@ func (m *MockClient) CreatePayment(ctx context.Context, req CreatePaymentReq) (*
func (m *MockClient) CreateCheckout(ctx context.Context, req CreateCheckoutReq) (*CheckoutResult, error) {
log.Printf("[SQUARE-MOCK] CreateCheckout: amount=%d, tipEnabled=%v, reference=%s", req.Amount, req.TipEnabled, req.ReferenceID)
checkoutID := fmt.Sprintf("chk_mock_%d", time.Now().UnixNano())
checkoutID := fmt.Sprintf("chk_mock_%d", clock.Now().UnixNano())
result := &CheckoutResult{
ID: checkoutID,
Status: "PENDING",
@@ -118,12 +119,17 @@ func (m *MockClient) CreateCheckout(ctx context.Context, req CreateCheckoutReq)
m.mu.Unlock()
go func() {
defer func() {
if r := recover(); r != nil {
log.Printf("Panic recovered in Square mock payment processing: %v", r)
}
}()
mockSleep(3 * time.Second)
m.mu.Lock()
defer m.mu.Unlock()
paymentID := fmt.Sprintf("pay_%d", time.Now().UnixNano())
paymentID := fmt.Sprintf("pay_%d", clock.Now().UnixNano())
amount := req.Amount
tipAmount := int64(0)
if req.TipEnabled {
@@ -184,7 +190,7 @@ func (m *MockClient) RefundPayment(ctx context.Context, req RefundPaymentReq) (*
m.mu.Lock()
defer m.mu.Unlock()
refundID := fmt.Sprintf("ref_mock_%d", time.Now().UnixNano())
refundID := fmt.Sprintf("ref_mock_%d", clock.Now().UnixNano())
amount := req.Amount
if amount == 0 {
if payment, ok := m.payments[req.PaymentID]; ok {
@@ -212,7 +218,7 @@ func (m *MockClient) CreateCardOnFile(ctx context.Context, userID, cardToken str
m.cards[userID] = make(map[string]*CardOnFile)
}
cardID := fmt.Sprintf("mock_card_%d", time.Now().UnixNano())
cardID := fmt.Sprintf("mock_card_%d", clock.Now().UnixNano())
card := &CardOnFile{
ID: cardID,
CardID: "cfa_" + cardID,
@@ -220,7 +226,7 @@ func (m *MockClient) CreateCardOnFile(ctx context.Context, userID, cardToken str
Last4: "4242",
ExpMonth: 12,
ExpYear: 2030,
Fingerprint: fmt.Sprintf("fp_%d", time.Now().UnixNano()),
Fingerprint: fmt.Sprintf("fp_%d", clock.Now().UnixNano()),
IsDefault: len(m.cards[userID]) == 0,
}
m.cards[userID][cardID] = card
@@ -238,7 +244,7 @@ func (m *MockClient) CreateCardOnFileRaw(ctx context.Context, userID, cardNumber
m.cards[userID] = make(map[string]*CardOnFile)
}
cardID := fmt.Sprintf("mock_card_%d", time.Now().UnixNano())
cardID := fmt.Sprintf("mock_card_%d", clock.Now().UnixNano())
last4 := cardNumber[len(cardNumber)-4:]
brands := map[string]string{"4": "VISA", "5": "MASTERCARD", "3": "AMEX", "6": "DISCOVER"}
brand := brands[string(cardNumber[0])]
@@ -253,7 +259,7 @@ func (m *MockClient) CreateCardOnFileRaw(ctx context.Context, userID, cardNumber
Last4: last4,
ExpMonth: expMonth,
ExpYear: expYear,
Fingerprint: fmt.Sprintf("fp_%d", time.Now().UnixNano()),
Fingerprint: fmt.Sprintf("fp_%d", clock.Now().UnixNano()),
IsDefault: len(m.cards[userID]) == 0,
}
m.cards[userID][cardID] = card