popertots/Crussell
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test fixes

Browse Source
This commit is contained in:
popertots
2026-03-01 16:05:02 +00:00
parent e00740a8c9
commit 803aab7073
6 changed files with 1652 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/handlers/user/profile_test.go
+297
View File
@@ -4,6 +4,24 @@
package user
import (
"bytes"
"context"
"encoding/json"
"io"
"mime/multipart"
"net/http"
"net/http/httptest"
"testing"
"crussell/db"
"crussell/internal/s3"
"crussell/mw"
"crussell/testutils/fixtures"
"crussell/testutils/jwt"
"crussell/testutils/testdb"
"github.com/jackc/pgx/v5/pgxpool"
)
"bytes"
"context"
"encoding/json"
@@ -175,6 +193,49 @@ func TestPasswordChange_WrongOld(t *testing.T) {
}
}
func TestPasswordChange_InvalidNewPassword(t *testing.T) {
cleanup, pool := setupTest(t)
defer cleanup()
userID, err := fixtures.CreateTestUser(pool)
if err != nil {
t.Fatalf("failed to create test user: %v", err)
}
token := jwt.GenerateUserToken(userID)
tests := []struct {
name string
newPassword string
}{
{"too_short", "short"},
{"too_long", "passwordthatiswaytoolongandexceedsseventytwocharacterswhichisthemaximumallowedbybcrypt"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
changeReq := ChangePasswordRequest{
CurrentPassword: "testpassword123",
NewPassword: tt.newPassword,
}
body, _ := json.Marshal(changeReq)
req := httptest.NewRequest(http.MethodPut, "/api/user/change-password", bytes.NewReader(body))
req = req.WithContext(context.WithValue(context.Background(), mw.UserIDKey, userID))
req.Header.Set("Authorization", "Bearer "+token)
req.Header.Set("Content-Type", "application/json")
rr := httptest.NewRecorder()
ChangePasswordHandler(rr, req)
if rr.Code != http.StatusBadRequest {
t.Errorf("expected status 400, got %d", rr.Code)
t.Logf("response body: %s", rr.Body.String())
}
})
}
}
func TestAccount_Delete(t *testing.T) {
cleanup, pool := setupTest(t)
defer cleanup()
@@ -241,3 +302,239 @@ func TestLoyalty_Get(t *testing.T) {
t.Error("expected referral code to be set")
}
}
func TestProfile_Update_InvalidInput(t *testing.T) {
cleanup, pool := setupTest(t)
defer cleanup()
userID, err := fixtures.CreateTestUser(pool)
if err != nil {
t.Fatalf("failed to create test user: %v", err)
}
token := jwt.GenerateUserToken(userID)
tests := []struct {
name string
req UpdateProfileRequest
expected int
}{
{
name: "missing_first_name",
req: UpdateProfileRequest{FirstName: "", LastName: "Doe", Phone: "+447700900000"},
expected: http.StatusBadRequest,
},
{
name: "missing_last_name",
req: UpdateProfileRequest{FirstName: "John", LastName: "", Phone: "+447700900000"},
expected: http.StatusBadRequest,
},
{
name: "missing_phone",
req: UpdateProfileRequest{FirstName: "John", LastName: "Doe", Phone: ""},
expected: http.StatusBadRequest,
},
{
name: "invalid_phone",
req: UpdateProfileRequest{FirstName: "John", LastName: "Doe", Phone: "not-a-phone"},
expected: http.StatusBadRequest,
},
{
name: "invalid_characters_in_name",
req: UpdateProfileRequest{FirstName: "John123", LastName: "Doe", Phone: "+447700900000"},
expected: http.StatusBadRequest,
},
{
name: "name_too_long",
req: UpdateProfileRequest{FirstName: string(make([]byte, 51)), LastName: "Doe", Phone: "+447700900000"},
expected: http.StatusBadRequest,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
body, _ := json.Marshal(tt.req)
req := httptest.NewRequest(http.MethodPut, "/api/user/profile", bytes.NewReader(body))
req = req.WithContext(context.WithValue(context.Background(), mw.UserIDKey, userID))
req.Header.Set("Authorization", "Bearer "+token)
req.Header.Set("Content-Type", "application/json")
rr := httptest.NewRecorder()
UpdateProfileHandler(rr, req)
if rr.Code != tt.expected {
t.Errorf("expected status %d, got %d", tt.expected, rr.Code)
t.Logf("response body: %s", rr.Body.String())
}
})
}
}
func TestProfile_Update_Success(t *testing.T) {
cleanup, pool := setupTest(t)
defer cleanup()
userID, err := fixtures.CreateTestUser(pool)
if err != nil {
t.Fatalf("failed to create test user: %v", err)
}
token := jwt.GenerateUserToken(userID)
updateReq := UpdateProfileRequest{
FirstName: "John",
LastName: "Doe",
Phone: "+447700900000",
}
body, _ := json.Marshal(updateReq)
req := httptest.NewRequest(http.MethodPut, "/api/user/profile", bytes.NewReader(body))
req = req.WithContext(context.WithValue(context.Background(), mw.UserIDKey, userID))
req.Header.Set("Authorization", "Bearer "+token)
req.Header.Set("Content-Type", "application/json")
rr := httptest.NewRecorder()
UpdateProfileHandler(rr, req)
if rr.Code != http.StatusOK {
t.Errorf("expected status 200, got %d", rr.Code)
t.Logf("response body: %s", rr.Body.String())
return
}
// Verify DB was updated
var firstName, lastName, phone string
err = pool.QueryRow(context.Background(),
"SELECT n_first_name, n_last_name, phone FROM users WHERE id = $1", userID).Scan(&firstName, &lastName, &phone)
if err != nil {
t.Fatalf("failed to query user: %v", err)
}
if firstName != "John" {
t.Errorf("expected first name 'John', got '%s'", firstName)
}
if lastName != "Doe" {
t.Errorf("expected last name 'Doe', got '%s'", lastName)
}
if phone != "+447700900000" {
t.Errorf("expected phone '+447700900000', got '%s'", phone)
}
}
func TestPasswordChange_SameAsOld(t *testing.T) {
cleanup, pool := setupTest(t)
defer cleanup()
userID, err := fixtures.CreateTestUser(pool)
if err != nil {
t.Fatalf("failed to create test user: %v", err)
}
token := jwt.GenerateUserToken(userID)
// Try to change password to the same one
changeReq := ChangePasswordRequest{
CurrentPassword: "testpassword123",
NewPassword: "testpassword123",
}
body, _ := json.Marshal(changeReq)
req := httptest.NewRequest(http.MethodPut, "/api/user/change-password", bytes.NewReader(body))
req = req.WithContext(context.WithValue(context.Background(), mw.UserIDKey, userID))
req.Header.Set("Authorization", "Bearer "+token)
req.Header.Set("Content-Type", "application/json")
rr := httptest.NewRecorder()
ChangePasswordHandler(rr, req)
// Should return 400 Bad Request - cannot use same password
if rr.Code != http.StatusBadRequest {
t.Errorf("expected status 400, got %d", rr.Code)
t.Logf("response body: %s", rr.Body.String())
}
}
func TestProfile_UploadPicture(t *testing.T) {
cleanup, pool := setupTest(t)
defer cleanup()
userID, err := fixtures.CreateTestUser(pool)
if err != nil {
t.Fatalf("failed to create test user: %v", err)
}
token := jwt.GenerateUserToken(userID)
// Create a small valid JPEG image (1x1 pixel)
// This is a minimal valid JPEG
fakeImage := []byte{
0xFF, 0xD8, 0xFF, 0xE0, 0x00, 0x10, 0x4A, 0x46, 0x49, 0x46, 0x00, 0x01,
0x01, 0x00, 0x00, 0x01, 0x00, 0x01, 0x00, 0x00, 0xFF, 0xDB, 0x00, 0x43,
0x00, 0x08, 0x06, 0x06, 0x07, 0x06, 0x05, 0x08, 0x07, 0x07, 0x07, 0x09,
0x09, 0x08, 0x0A, 0x0C, 0x14, 0x0D, 0x0C, 0x0B, 0x0B, 0x0C, 0x19, 0x12,
0x13, 0x0F, 0x14, 0x1D, 0x1A, 0x1F, 0x1E, 0x1D, 0x1A, 0x1C, 0x1C, 0x20,
0x24, 0x2E, 0x27, 0x20, 0x22, 0x2C, 0x23, 0x1C, 0x1C, 0x28, 0x37, 0x29,
0x2C, 0x30, 0x31, 0x34, 0x34, 0x34, 0x1F, 0x27, 0x39, 0x3D, 0x38, 0x32,
0x3C, 0x2E, 0x33, 0x34, 0x32, 0xFF, 0xC0, 0x00, 0x0B, 0x08, 0x00, 0x01,
0x00, 0x01, 0x01, 0x01, 0x11, 0x00, 0xFF, 0xC4, 0x00, 0x1F, 0x00, 0x00,
0x01, 0x05, 0x01, 0x01, 0x01, 0x01, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09,
0x0A, 0x0B, 0xFF, 0xC4, 0x00, 0xB5, 0x10, 0x00, 0x02, 0x01, 0x03, 0x03,
0x02, 0x04, 0x03, 0x05, 0x05, 0x04, 0x04, 0x00, 0x00, 0x01, 0x7D, 0x01, 0x02,
0x03, 0x00, 0x04, 0x11, 0x05, 0x12, 0x21, 0x31, 0x41, 0x06, 0x13, 0x51, 0x61,
0x07, 0x22, 0x71, 0x14, 0x32, 0x81, 0x91, 0xA1, 0x08, 0x23, 0x42, 0xB1, 0xC1,
0x15, 0x52, 0xD1, 0xF0, 0x24, 0x33, 0x62, 0x72, 0x82, 0x09, 0x0A, 0x16, 0x17,
0x18, 0x19, 0x1A, 0x25, 0x26, 0x27, 0x28, 0x29, 0x2A, 0x34, 0x35, 0x36, 0x37,
0x38, 0x39, 0x3A, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48, 0x49, 0x4A, 0x53, 0x54,
0x55, 0x56, 0x57, 0x58, 0x59, 0x5A, 0x63, 0x64, 0x65, 0x66, 0x67, 0x68, 0x69,
0x6A, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79, 0x7A, 0x83, 0x84, 0x85, 0x86,
0x87, 0x88, 0x89, 0x8A, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97, 0x98, 0x99, 0x9A,
0xA2, 0xA3, 0xA4, 0xA5, 0xA6, 0xA7, 0xA8, 0xA9, 0xAA, 0xB2, 0xB3, 0xB4, 0xB5,
0xB6, 0xB7, 0xB8, 0xB9, 0xBA, 0xC2, 0xC3, 0xC4, 0xC5, 0xC6, 0xC7, 0xC8, 0xC9,
0xCA, 0xD2, 0xD3, 0xD4, 0xD5, 0xD6, 0xD7, 0xD8, 0xD9, 0xDA, 0xE1, 0xE2, 0xE3,
0xE4, 0xE5, 0xE6, 0xE7, 0xE8, 0xE9, 0xEA, 0xF1, 0xF2, 0xF3, 0xF4, 0xF5, 0xF6,
0xF7, 0xF8, 0xF9, 0xFA, 0xFF, 0xDA, 0x00, 0x08, 0x01, 0x01, 0x00, 0x00, 0x3F,
0x00, 0xFB, 0xD5, 0xDB, 0x20, 0xA8, 0xF8, 0xAF, 0xFF, 0xD9,
}
// Create multipart form request
var b bytes.Buffer
writer := multipart.NewWriter(&b)
part, err := writer.CreateFormFile("file", "test.jpg")
if err != nil {
t.Fatalf("failed to create form file: %v", err)
}
_, err = part.Write(fakeImage)
if err != nil {
t.Fatalf("failed to write image: %v", err)
}
writer.Close()
req := httptest.NewRequest(http.MethodPost, "/api/user/profile-picture", &b)
req = req.WithContext(context.WithValue(context.Background(), mw.UserIDKey, userID))
req.Header.Set("Authorization", "Bearer "+token)
req.Header.Set("Content-Type", writer.FormDataContentType())
rr := httptest.NewRecorder()
// Note: This test may return 500 if S3 is not configured
// In that case, we check for either success or proper error handling
if rr.Code != http.StatusOK && rr.Code != http.StatusInternalServerError {
t.Errorf("expected status 200 or 500 (if S3 not configured), got %d", rr.Code)
t.Logf("response body: %s", rr.Body.String())
}
// If S3 is configured, verify the response contains a URL
if rr.Code == http.StatusOK {
var resp map[string]string
if err := json.Unmarshal(rr.Body.Bytes(), &resp); err != nil {
t.Fatalf("failed to unmarshal response: %v", err)
}
if resp["profilePicUrl"] == "" {
t.Error("expected profilePicUrl in response")
}
}
}