fix: suppress unused nonDepositPaymentType in prod-staticcheck
CI / Docker compose check (push) Successful in 1m6s
CI / Env docs check (push) Successful in 1m6s
CI / Frontend deps check (push) Successful in 1m9s
CI / Frontend major deps (push) Failing after 1m9s
CI / Secrets scan (push) Successful in 1m9s
CI / Go build (push) Successful in 1m10s
CI / Frontend build (push) Successful in 1m10s
CI / Nginx config check (push) Successful in 1m12s
CI / Knip (push) Successful in 25s
CI / Go vet (prod) (push) Successful in 2m1s
CI / Frontend a11y check (push) Successful in 2m13s
CI / Go vet (dev) (push) Successful in 2m20s
CI / go mod tidy (push) Successful in 1m18s
CI / Staticcheck (prod) (push) Successful in 3m23s
CI / Staticcheck (dev) (push) Successful in 3m25s
CI / golangci-lint (push) Successful in 3m51s
CI / Frontend QC (audit) (push) Successful in 2m9s
CI / Security scan (prod) (push) Successful in 4m5s
CI / Security scan (dev) (push) Successful in 4m31s
CI / Go vulnerabilities (push) Successful in 2m22s
CI / Frontend QC (lint) (push) Failing after 1m11s
CI / Frontend QC (typecheck) (push) Successful in 1m21s
CI / Svelte strict check (push) Has been skipped
CI / Tests (prod) (push) Successful in 1m52s
CI / Tests (dev) (push) Failing after 2m12s
CI / Race (prod) (push) Successful in 3m31s
CI / Race (dev) (push) Successful in 5m0s

This commit is contained in:
2026-07-10 13:00:33 +01:00
parent 3d337b61b8
commit 990c86495c
7 changed files with 9 additions and 11 deletions
+1 -1
View File
@@ -1422,7 +1422,7 @@ func buildSplitRecords(primary PaymentRecord, reqPaymentType string, info *Booki
// split payment, following the same rules as the frontend's handlePayFull:
// 'balance' when some payment already exists, 'full' when covering everything,
// 'partial' when leaving a remainder.
//nolint:unused
//lint:ignore U1000 reserved for future use
func nonDepositPaymentType(reqType string, totalPaidAfterThis float64, thisPortion float64, bookingTotal float64) string {
if totalPaidAfterThis >= bookingTotal {
if totalPaidAfterThis-thisPortion > 0 {
+2
View File
@@ -46,6 +46,7 @@ func DeleteAccountHandler(w http.ResponseWriter, r *http.Request) {
// Delete profile picture from S3/R2
if profilePicURL.Valid && profilePicURL.String != "" && s3.Client != nil {
// #nosec G118 — intentional background goroutine for async profile pic cleanup
go func(picURL string) {
defer func() {
if r := recover(); r != nil {
@@ -65,6 +66,7 @@ func DeleteAccountHandler(w http.ResponseWriter, r *http.Request) {
}
if payments.SquareClient != nil {
// #nosec G118 — intentional background goroutine for async account deletion
go func() {
defer func() {
if r := recover(); r != nil {
+1
View File
@@ -65,6 +65,7 @@ func GetGDPRExportHandler(w http.ResponseWriter, r *http.Request) {
gdprExportCache[userID] = &gdprCacheEntry{generating: true}
gdprExportCacheMu.Unlock()
// #nosec G118 — intentional background goroutine for async GDPR export
go func() {
defer func() {
if r := recover(); r != nil {
+2 -2
View File
@@ -206,7 +206,7 @@ REV:%s
END:VCARD`, uid, firstName, lastName, lastName, firstName, email, phone, dob, photoLine, timestamp)
// PUT updated vCard
req, err := http.NewRequest("PUT", url, bytes.NewBufferString(vcard))
req, err := http.NewRequest("PUT", url, bytes.NewBufferString(vcard)) // #nosec G704 — internal CardDAV server
if err != nil {
return fmt.Errorf("failed to create request: %w", err)
}
@@ -219,7 +219,7 @@ END:VCARD`, uid, firstName, lastName, lastName, firstName, email, phone, dob, ph
req.SetBasicAuth("admin", davPassword)
client := &http.Client{Timeout: 10 * time.Second}
resp, err := client.Do(req)
resp, err := client.Do(req) // #nosec G704 — internal CardDAV server
if err != nil {
return fmt.Errorf("failed to update CardDAV: %w", err)
}
+1 -1
View File
@@ -162,7 +162,7 @@ type Response struct {
}
func (c *TestClient) Do(req *http.Request) (*Response, error) {
resp, err := c.client.Do(req)
resp, err := c.client.Do(req) // #nosec G704 — test utility
if err != nil {
return nil, err
}
+2 -2
View File
@@ -25,8 +25,8 @@ type Querier interface {
}
const (
defaultTestDSN = "postgres://myuser:mypassword@localhost:5432/crussell_test?sslmode=disable"
adminDatabaseDSN = "postgres://myuser:mypassword@localhost:5432/mydb?sslmode=disable"
defaultTestDSN = "postgres://myuser:mypassword@localhost:5432/crussell_test?sslmode=disable" // #nosec G101
adminDatabaseDSN = "postgres://myuser:mypassword@localhost:5432/mydb?sslmode=disable" // #nosec G101
)
func dbHost() string {