popertots/Crussell
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add error logging to 3 non-aggregate nolint:errcheck sites (duration lookup, deposit-paid scans)

Browse Source
This commit is contained in:
popertots
2026-07-11 14:41:06 +01:00
parent d410dce0e0
commit 9b235a1298
2 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/handlers/bookings/bookings.go
+6 -6
View File
@@ -1998,8 +1998,9 @@ func CreateBookingHandler(w http.ResponseWriter, r *http.Request) {
// Get payment info
var preStartPaid float64
//nolint:errcheck // zero value is acceptable fallback on scan failure
_ = db.Conn.QueryRow(r.Context(), `SELECT COALESCE(SUM(amount), 0) FROM payments WHERE booking_id = $1 AND payment_type IN ('deposit', 'full') AND status = 'completed'`, existingBooking.ID).Scan(&preStartPaid)
if err := db.Conn.QueryRow(r.Context(), `SELECT COALESCE(SUM(amount), 0) FROM payments WHERE booking_id = $1 AND payment_type IN ('deposit', 'full') AND status = 'completed'`, existingBooking.ID).Scan(&preStartPaid); err != nil {
log.Printf("Failed to scan preStartPaid for booking %s: %v", existingBooking.ID, err)
}
populateDepositFields(&existingBooking, existingBooking.DepositRequired, preStartPaid)
w.Header().Set("Content-Type", "application/json")
@@ -3158,11 +3159,10 @@ func ConfirmBookingHandler(w http.ResponseWriter, r *http.Request) {
if dav.Service != nil {
var durationMinutes int
//nolint:errcheck // zero value is acceptable fallback on scan failure
_ = db.Conn.QueryRow(r.Context(), `
if err := db.Conn.QueryRow(r.Context(), `
SELECT total_duration_minutes FROM bookings WHERE id = $1
`, bookingID).Scan(&durationMinutes)
if durationMinutes == 0 {
`, bookingID).Scan(&durationMinutes); err != nil {
log.Printf("ALERT: failed to scan total_duration_minutes for booking %s: %v", bookingID, err)
durationMinutes = 60
}
_ = dav.Service.CreateEvent(1, dav.EventInput{
backend/handlers/bookings/manage.go
+3 -2
View File
@@ -413,8 +413,9 @@ func AdminCreateBookingForUserHandler(w http.ResponseWriter, r *http.Request) {
// Get deposit info — deposit_required already fetched above in the main booking query.
var preStartPaid float64
//nolint:errcheck // zero value is acceptable fallback on scan failure (aggregate with COALESCE)
_ = db.Conn.QueryRow(r.Context(), `SELECT COALESCE(SUM(amount), 0) FROM payments WHERE booking_id = $1 AND payment_type IN ('deposit', 'full') AND status = 'completed'`, existingID).Scan(&preStartPaid)
if err := db.Conn.QueryRow(r.Context(), `SELECT COALESCE(SUM(amount), 0) FROM payments WHERE booking_id = $1 AND payment_type IN ('deposit', 'full') AND status = 'completed'`, existingID).Scan(&preStartPaid); err != nil {
log.Printf("Failed to scan preStartPaid for booking %s: %v", existingID, err)
}
populateDepositFields(&existingBooking, existingBooking.DepositRequired, preStartPaid)
w.Header().Set("Content-Type", "application/json")