feat: add comprehensive test suite for recent backend changes

2026-05-29 17:13:16 +01:00
parent 9ba4949d37
commit 9d8015f1b8
5 changed files with 339 additions and 68 deletions
@@ -0,0 +1,159 @@
+//go:build test
+// +build test
+
+package admin
+
+import (
+	"context"
+	"net/http"
+	"testing"
+	"time"
+
+	"crussell/db"
+	"crussell/handlers/bookings"
+	"crussell/testutils/fixtures"
+)
+
+// TestGetOverlappingBookingsByTime verifies the new overlapping bookings endpoint
+func TestGetOverlappingBookingsByTime(t *testing.T) {
+	resetTestData(t)
+
+	adminID, err := fixtures.CreateTestAdminUser(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create admin user: %v", err)
+	}
+	defer fixtures.DeleteUser(db.DB, adminID)
+
+	userID, err := fixtures.CreateTestUser(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create test user: %v", err)
+	}
+	defer fixtures.DeleteUser(db.DB, userID)
+
+	serviceID, err := fixtures.CreateTestService(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create test service: %v", err)
+	}
+	defer fixtures.DeleteService(db.DB, serviceID)
+
+	startTime := time.Date(2026, 3, 16, 10, 0, 0, 0, time.UTC)
+	bookingID, err := fixtures.CreateTestBookingAtTime(db.DB, userID, serviceID, startTime)
+	if err != nil {
+		t.Fatalf("failed to create test booking: %v", err)
+	}
+	defer fixtures.DeleteBooking(db.DB, bookingID)
+
+	handler := http.HandlerFunc(bookings.GetOverlappingBookingsByTimeHandler)
+	w := makeAdminRequest(handler, "GET", "/api/admin/bookings/overlapping?start=2026-03-16T09:00:00Z&end=2026-03-16T11:00:00Z", nil)
+
+	if w.Code != http.StatusOK {
+		t.Errorf("expected status 200, got %d. body: %s", w.Code, w.Body.String())
+	}
+
+	var resp bookings.OverlappingBookingsResponse
+	if err := parseResponseBody(w, &resp); err != nil {
+		t.Fatalf("failed to parse response: %v", err)
+	}
+
+	if len(resp.Bookings) != 1 {
+		t.Errorf("expected 1 overlapping booking, got %d", len(resp.Bookings))
+	}
+}
+
+// TestGetBookingsByDateRange verifies the new bookings by date range endpoint
+func TestGetBookingsByDateRange(t *testing.T) {
+	resetTestData(t)
+
+	adminID, err := fixtures.CreateTestAdminUser(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create admin user: %v", err)
+	}
+	defer fixtures.DeleteUser(db.DB, adminID)
+
+	userID, err := fixtures.CreateTestUser(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create test user: %v", err)
+	}
+	defer fixtures.DeleteUser(db.DB, userID)
+
+	serviceID, err := fixtures.CreateTestService(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create test service: %v", err)
+	}
+	defer fixtures.DeleteService(db.DB, serviceID)
+
+	startTime := time.Date(2026, 3, 16, 10, 0, 0, 0, time.UTC)
+	bookingID, err := fixtures.CreateTestBookingAtTime(db.DB, userID, serviceID, startTime)
+	if err != nil {
+		t.Fatalf("failed to create test booking: %v", err)
+	}
+	defer fixtures.DeleteBooking(db.DB, bookingID)
+
+	handler := http.HandlerFunc(bookings.GetBookingsByDateRangeHandler)
+	w := makeAdminRequest(handler, "GET", "/api/admin/bookings/by-date-range?start=2026-03-16&end=2026-03-16", nil)
+
+	if w.Code != http.StatusOK {
+		t.Errorf("expected status 200, got %d. body: %s", w.Code, w.Body.String())
+	}
+
+	var resp bookings.OverlappingBookingsResponse
+	if err := parseResponseBody(w, &resp); err != nil {
+		t.Fatalf("failed to parse response: %v", err)
+	}
+
+	if len(resp.Bookings) != 1 {
+		t.Errorf("expected 1 booking, got %d", len(resp.Bookings))
+	}
+}
+
+// TestAdminRescheduleBooking verifies the new reschedule endpoint
+func TestAdminRescheduleBooking(t *testing.T) {
+	resetTestData(t)
+
+	adminID, err := fixtures.CreateTestAdminUser(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create admin user: %v", err)
+	}
+	defer fixtures.DeleteUser(db.DB, adminID)
+
+	userID, err := fixtures.CreateTestUser(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create test user: %v", err)
+	}
+	defer fixtures.DeleteUser(db.DB, userID)
+
+	serviceID, err := fixtures.CreateTestService(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create test service: %v", err)
+	}
+	defer fixtures.DeleteService(db.DB, serviceID)
+
+	startTime := time.Now().Add(48 * time.Hour).Truncate(time.Second)
+	bookingID, err := fixtures.CreateTestBookingAtTime(db.DB, userID, serviceID, startTime)
+	if err != nil {
+		t.Fatalf("failed to create test booking: %v", err)
+	}
+	defer fixtures.DeleteBooking(db.DB, bookingID)
+
+	newStartTime := startTime.Add(2 * time.Hour)
+	req := map[string]interface{}{
+		"start_time": newStartTime.Format(time.RFC3339),
+	}
+
+	handler := http.HandlerFunc(bookings.AdminRescheduleBookingHandler)
+	w := makeAdminRequest(handler, "PUT", "/api/admin/bookings/"+bookingID+"/reschedule", req)
+
+	if w.Code != http.StatusOK {
+		t.Errorf("expected status 200, got %d. body: %s", w.Code, w.Body.String())
+	}
+
+	var dbStartTime time.Time
+	err = db.DB.QueryRow(context.Background(),
+		"SELECT start_time FROM bookings WHERE id = $1", bookingID).Scan(&dbStartTime)
+	if err != nil {
+		t.Fatalf("failed to query booking: %v", err)
+	}
+	if !dbStartTime.Truncate(time.Second).Equal(newStartTime.Truncate(time.Second)) {
+		t.Errorf("expected booking start_time %v, got %v", newStartTime, dbStartTime)
+	}
+}
@@ -0,0 +1,76 @@
+//go:build test
+// +build test
+
+package admin
+
+import (
+	"context"
+	"net/http"
+	"testing"
+
+	"crussell/db"
+	"crussell/handlers/bookings"
+	"crussell/testutils/fixtures"
+)
+
+// TestAdminBookings_Get_EnrichedFields verifies that CreatedByName and User.DateOfBirth are populated.
+func TestAdminBookings_Get_EnrichedFields(t *testing.T) {
+	resetTestData(t)
+
+	adminID, err := fixtures.CreateTestAdminUser(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create admin user: %v", err)
+	}
+	defer fixtures.DeleteUser(db.DB, adminID)
+
+	userID, err := fixtures.CreateTestUser(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create test user: %v", err)
+	}
+	defer fixtures.DeleteUser(db.DB, userID)
+
+	serviceID, err := fixtures.CreateTestService(db.DB)
+	if err != nil {
+		t.Fatalf("failed to create test service: %v", err)
+	}
+	defer fixtures.DeleteService(db.DB, serviceID)
+
+	bookingID, err := fixtures.CreateTestBooking(db.DB, userID, serviceID)
+	if err != nil {
+		t.Fatalf("failed to create test booking: %v", err)
+	}
+	defer fixtures.DeleteBooking(db.DB, bookingID)
+
+	dob := "1990-01-01"
+	_, err = db.DB.Exec(context.Background(), "UPDATE users SET date_of_birth = $1 WHERE id = $2", dob, userID)
+	if err != nil {
+		t.Fatalf("failed to update user dob: %v", err)
+	}
+
+	_, err = db.DB.Exec(context.Background(), "UPDATE bookings SET created_by = $1 WHERE id = $2", adminID, bookingID)
+	if err != nil {
+		t.Fatalf("failed to update booking created_by: %v", err)
+	}
+
+	handler := http.HandlerFunc(bookings.GetAdminBookingHandler)
+	w := makeAdminRequest(handler, "GET", "/api/admin/bookings/"+bookingID, nil)
+
+	if w.Code != http.StatusOK {
+		t.Errorf("expected status 200, got %d. body: %s", w.Code, w.Body.String())
+	}
+
+	var booking bookings.Booking
+	if err := parseResponseBody(w, &booking); err != nil {
+		t.Fatalf("failed to parse response: %v", err)
+	}
+
+	if booking.CreatedByName == nil {
+		t.Error("expected CreatedByName to be populated")
+	}
+
+	if booking.User == nil || booking.User.DateOfBirth == nil {
+		t.Error("expected User.DateOfBirth to be populated")
+	} else if *booking.User.DateOfBirth != dob {
+		t.Errorf("expected date_of_birth %s, got %s", dob, *booking.User.DateOfBirth)
+	}
+}