fix: replace time.Sleep with poll loops in tests, fix a11y target=_blank violations

backend/handlers/bookings/edit_requests_test.go

@@ -39,6 +39,7 @@ import (
 	"crussell/testutils/jwt"
 
 	"github.com/go-chi/chi/v5"
+	"github.com/stretchr/testify/assert"
 )
 
 // =============================================================================
@@ -2303,8 +2304,10 @@ func TestRequestEditHandler_NotificationUpsertOnReplace(t *testing.T) {
 		t.Fatalf("expected 1 notification after first request, got %d", notifCount)
 	}
 
-	// Wait a moment so timestamps differ
-	time.Sleep(100 * time.Millisecond)
+	// Ensure time has advanced past firstCreatedAt so the next notification has a distinct timestamp
+	assert.Eventually(t, func() bool {
+		return time.Now().After(firstCreatedAt.Add(time.Millisecond))
+	}, 5*time.Second, time.Millisecond, "timed out waiting for time to advance")
 
 	// Create second edit request (upsert)
 	w = makeRequest(handler, "POST", "/api/bookings/"+bookingID+"/edit-request",
@@ -2332,6 +2335,9 @@ func TestRequestEditHandler_NotificationUpsertOnReplace(t *testing.T) {
 	if err != nil {
 		t.Fatalf("expected notification to exist after upsert: %v", err)
 	}
+	if !secondCreatedAt.After(firstCreatedAt) {
+		t.Errorf("expected notification created_at to be newer than original: first=%v, second=%v", firstCreatedAt, secondCreatedAt)
+	}
 }
 
 // TestAdminApproveEditRequest_ClosedExceptionalHours_Rejected verifies that admin cannot approve an edit request