fix: add error logging to remaining nolint:errcheck scan sites for observability

2026-07-11 15:04:53 +01:00
parent ad15127777
commit f147be0b99
7 changed files with 90 additions and 61 deletions
@@ -565,13 +565,15 @@ func ListAdminUsersHandler(w http.ResponseWriter, r *http.Request) {
 	// Run BEFORE the data query to avoid "conn busy" errors when routing
 	// through a per-test transaction (pgx.Tx does not support concurrent queries).
 	if searchTerm != "" {
-		//nolint:errcheck // zero value is acceptable fallback on scan failure
-		_ = db.Conn.QueryRow(r.Context(), `SELECT COUNT(DISTINCT u.id) FROM users u
+		if err := db.Conn.QueryRow(r.Context(), `SELECT COUNT(DISTINCT u.id) FROM users u
 			LEFT JOIN bookings b ON u.id = b.user_id
-			WHERE u.fn ILIKE $1 OR u.email ILIKE $1 OR u.phone ILIKE $1`, "%"+searchTerm+"%").Scan(&total)
+			WHERE u.fn ILIKE $1 OR u.email ILIKE $1 OR u.phone ILIKE $1`, "%"+searchTerm+"%").Scan(&total); err != nil {
+			log.Printf("Failed to scan filtered user count: %v", err)
+		}
 	} else {
-		//nolint:errcheck // zero value is acceptable fallback on scan failure
-		_ = db.Conn.QueryRow(r.Context(), "SELECT COUNT(*) FROM users").Scan(&total)
+		if err := db.Conn.QueryRow(r.Context(), "SELECT COUNT(*) FROM users").Scan(&total); err != nil {
+			log.Printf("Failed to scan user count: %v", err)
+		}
 	}

 	// Get users list