fix: auth/2FA security — stdout-log code delivery is dev/test-only, production fails closed until email/SMS; verification-code hashing, lockout recovery, sabredav fail-closed

- TWO_FACTOR_ALLOW_LOG_DELIVERY production opt-in REMOVED: plaintext codes are written to the stdout log ([2FA]/[VERIFY]) only in dev/test builds as a local DEV ONLY feature while email/SMS delivery (P6) is implemented. Production builds have no delivery channel and code issuance fails closed (503) under any configuration — no silent log-based code leak
- verification/2FA codes hashed at rest (HMAC-SHA256 via TWO_FACTOR_PEPPER, CHAR(64)); [VERIFY] dev log relay; per-user brute-force budget; password_reset purpose clears lockout for self-service recovery; dummy-bcrypt on login no-user path kills timing oracle
- sabredav weak-password list + entropy gate; .env.example ships fail-closed DAV_ADMIN_PASSWORD
- delete-account re-auth (current_password + fresh 2FA code when enforced)
- prod-tag suite (run-prod-tag-tests.sh) compiles and runs the production 2FA issuance gate: production ALWAYS reports no delivery channel and refuses issuance after the pepper check
- startup_checks_test SNAPSHOT_ENC_KEY values built at runtime so gitleaks sees no secret-shaped literals
- env-docs parity updated (flag removed, 38 vars)
This commit is contained in:
2026-08-22 00:34:50 +01:00
parent 1429eddd34
commit f9e8385d5a
19 changed files with 1047 additions and 472 deletions
+30
View File
@@ -0,0 +1,30 @@
//go:build dev || test
package auth
// Dev/test builds of the verification-code flow (POST /api/verify/generate):
// the [VERIFY] log line is the LOCAL DEV delivery channel — the stand-in for
// the not-yet-wired email/SMS transport (P6) — and a missing TWO_FACTOR_PEPPER
// still falls back to the legacy unsalted SHA-256 digest (via the shared
// crussell/internal/twofa provider, which logs its own one-time warning).
// Production builds (!dev && !test) never log the code — stdout-log delivery
// is a dev/test-only local feature — and fail closed — see verifycode_prod.go.
import "log"
// verificationCodeEnsureIssueAllowed always permits code issuance in dev/test
// builds: the loose-fake delivery (the [VERIFY] log line) is the documented
// stand-in until email/SMS lands. Production builds fail closed here — no
// TWO_FACTOR_PEPPER, no codes (see verifycode_prod.go).
func verificationCodeEnsureIssueAllowed() error { return nil }
// verificationCodeDeliver delivers a fresh verification code to the user.
// Dev/test: the [VERIFY] log line is the delivery channel — an operator relays
// the code to the user out-of-band until email/SMS lands (mirrors the [2FA]
// log relay, which the 2FA flow uses identically). MEDIUM-3b: the user id and
// the plaintext code go to SEPARATE log lines so a single record cannot trivially
// pair a code with its owner.
func verificationCodeDeliver(userID, purpose, code string) {
log.Printf("[VERIFY] code delivery requested (user=%s, purpose=%s)", userID, purpose)
log.Printf("[VERIFY] code: %s", code)
}