Files
Crussell/backend/internal/s3/s3_dev_test.go
T
popertots 78e6d00dc5 fix: payments review rounds — money-safety, GDPR, security, gift-card cancel, modal stacking
Money-safety:
- Deterministic till idempotency fallback (Square-charging only); cash/on_the_house keep unique keys; £250 till gift-card cap; 45-char key validation
- Gift-card admin caps £250/tx + £5,000/day; user buy £500/day; BuyGiftCard allowlist unchanged
- CancelGiftCard: CCR 2013 14-day right with partial-spend refund of the unspent balance (spend verified via payments.gift_card_id); atomic vs redeem/transfer; refunds stay pending until reversal commits; admin cancel surface (AdminCancelGiftCard)
- Sweep: cancelled-booking charges failed+notified instead of silently completed; source-override replay uses live square_source_id; legacy square-less refund sweep; snapshot refresh on pending reuse
- Refund lock consolidation; recordTerminalPaymentTx shared recorder; structured Square error codes; terminal checkout CustomerID

GDPR / security:
- Notes retained as de-identified medical/safety record at erasure (single field treated as health data; rest of record wiped, no re-identification map) + comments updated per UK GDPR/Art 9/Equality Act 2010
- square_request_snapshot PII scrubbed on all erasure paths; delete_guest_user FK unlinks; verification codes + dispute reasons handled; idle/stale-guest erasure deletes Square cards/customers + CardDAV/R2
- Durable square-erasure outbox job (retry-square-erasures); 2FA dev/prod build split, pepper fail-closed, no prod code-in-log; prod 2FA delivery fail-loud without a channel
- Webhook unknown-type family split (non-money acked, money retried); untracked dispute notifications; rate-limit CF/X-Real-IP trust gating; nginx CSP nonce + api_limit

Frontend:
- Dynamic z-index stack (ui/dialog/zindex.ts) claimed in open order via data-state observer; re-claims on every reopen; removes stale !z-* overrides — nested modals (booking→user→booking) always paint newest-on-top (browser-verified 3-level + reopen)
- Mobile: iOS zoom fixes, bottom-sheet dialogs, 44px touch targets, inputmode decimal, dvh
- Gift-card buy/cancel UI, admin £250 + daily limits, cancellation/privacy/terms policy accuracy

S3:
- Connect() creates buckets before probing; in-memory fallback only on genuine unreachability; health reports degraded; stale S3_PUBLIC_URL documented (host-specific)

Tests/docs:
- 2263 test functions; all 22 backend packages green; round8/9/10 regression suites; NextEditWindowTime removes wall-clock flake; docs reconciled (notes retention, gift-card partial-use, modal T15 future work)
2026-08-22 00:34:50 +01:00

218 lines
5.6 KiB
Go

//go:build test && dev
package s3
import (
"bytes"
"context"
"fmt"
"io"
"net"
"strings"
"sync"
"testing"
"github.com/aws/aws-sdk-go-v2/service/s3/types"
"github.com/aws/smithy-go"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestInMemS3_UploadAndDownload(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
body := "hello world"
err := s3.Upload(ctx, "bucket1", "key1", strings.NewReader(body), "text/plain")
require.NoError(t, err)
var buf bytes.Buffer
err = s3.Download(ctx, "bucket1", "key1", &buf)
require.NoError(t, err)
assert.Equal(t, body, buf.String())
}
func TestInMemS3_UploadOverwrite(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
err := s3.Upload(ctx, "bucket", "key", strings.NewReader("first"), "")
require.NoError(t, err)
err = s3.Upload(ctx, "bucket", "key", strings.NewReader("second"), "")
require.NoError(t, err)
var buf bytes.Buffer
err = s3.Download(ctx, "bucket", "key", &buf)
require.NoError(t, err)
assert.Equal(t, "second", buf.String())
}
func TestInMemS3_Download_NotFound(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
var buf bytes.Buffer
err := s3.Download(ctx, "bucket", "nonexistent", &buf)
assert.Error(t, err)
assert.Contains(t, err.Error(), "not found")
}
func TestInMemS3_Delete(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
err := s3.Upload(ctx, "bucket", "key", strings.NewReader("data"), "")
require.NoError(t, err)
err = s3.Delete(ctx, "bucket", "key")
assert.NoError(t, err)
var buf bytes.Buffer
err = s3.Download(ctx, "bucket", "key", &buf)
assert.Error(t, err)
assert.Contains(t, err.Error(), "not found")
}
func TestInMemS3_Delete_NotFound(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
err := s3.Delete(ctx, "bucket", "does-not-exist")
assert.NoError(t, err)
}
func TestInMemS3_GetURL(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
url, err := s3.GetURL(ctx, "mybucket", "mykey")
require.NoError(t, err)
assert.Equal(t, "https://cdn.example.com/mybucket/mykey", url)
}
func TestInMemS3_HealthCheck(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
err := s3.HealthCheck(ctx)
assert.NoError(t, err)
}
func TestInMemS3_ConcurrentUpload(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
var wg sync.WaitGroup
for i := 0; i < 10; i++ {
wg.Add(1)
go func(n int) {
defer wg.Done()
key := "key-" + string(rune('0'+n))
err := s3.Upload(ctx, "bucket", key, strings.NewReader("data"), "")
assert.NoError(t, err)
}(i)
}
wg.Wait()
for i := 0; i < 10; i++ {
key := "key-" + string(rune('0'+i))
var buf bytes.Buffer
err := s3.Download(ctx, "bucket", key, &buf)
assert.NoError(t, err)
assert.Equal(t, "data", buf.String())
}
}
func TestInMemS3_DownloadEmptyBody(t *testing.T) {
t.Parallel()
s3 := &inMemS3{objects: make(map[string][]byte)}
ctx := context.Background()
err := s3.Upload(ctx, "bucket", "empty", strings.NewReader(""), "")
require.NoError(t, err)
var buf bytes.Buffer
err = s3.Download(ctx, "bucket", "empty", &buf)
require.NoError(t, err)
assert.Equal(t, "", buf.String())
}
func TestConnect_FallbackToInMemory(t *testing.T) {
t.Parallel()
ctx := context.Background()
err := Connect()
assert.NoError(t, err)
assert.NotNil(t, Client)
var buf bytes.Buffer
err = Client.Download(ctx, "bucket", "nonexistent", &buf)
assert.Error(t, err)
assert.Contains(t, err.Error(), "not found")
}
func TestIsMissingBucket_NoSuchBucketGeneric(t *testing.T) {
t.Parallel()
err := &smithy.GenericAPIError{Code: "NoSuchBucket", Message: "bucket does not exist"}
assert.True(t, isMissingBucket(err))
}
func TestIsMissingBucket_NotFoundGeneric(t *testing.T) {
t.Parallel()
err := &smithy.GenericAPIError{Code: "NotFound", Message: "not found"}
assert.True(t, isMissingBucket(err))
}
func TestIsMissingBucket_NotFoundTyped(t *testing.T) {
t.Parallel()
// The concrete error types the vendored SDK surfaces for HeadBucket 404s.
assert.True(t, isMissingBucket(&types.NotFound{}))
assert.True(t, isMissingBucket(&types.NoSuchBucket{}))
}
func TestIsMissingBucket_NotFoundViaOperationError(t *testing.T) {
t.Parallel()
// The SDK wraps API errors in an OperationError; errors.As must still find it.
err := &smithy.OperationError{ServiceID: "S3", OperationName: "HeadBucket", Err: &types.NotFound{}}
assert.True(t, isMissingBucket(err))
}
func TestIsMissingBucket_NotFoundWrapped(t *testing.T) {
t.Parallel()
err := fmt.Errorf("head bucket: %w", &smithy.GenericAPIError{Code: "NoSuchBucket", Message: "x"})
assert.True(t, isMissingBucket(err))
}
func TestIsMissingBucket_ConnectionRefused(t *testing.T) {
t.Parallel()
err := &net.OpError{Op: "dial", Net: "tcp", Err: fmt.Errorf("connect: connection refused")}
assert.False(t, isMissingBucket(err))
}
func TestIsMissingBucket_EOF(t *testing.T) {
t.Parallel()
assert.False(t, isMissingBucket(io.EOF))
}
func TestIsMissingBucket_AccessDenied(t *testing.T) {
t.Parallel()
// Reachable but unauthorized is a connectivity/credentials problem, not a
// missing bucket — it must still trigger the fallback.
err := &types.AccessDenied{}
assert.False(t, isMissingBucket(err))
}
func TestIsMissingBucket_Nil(t *testing.T) {
t.Parallel()
assert.False(t, isMissingBucket(nil))
}