popertots
  • Joined on 2025-08-01
popertots pushed to main at popertots/Crussell 2026-08-22 00:35:07 +01:00
b8e521f4e7 test: frontend store coverage — auth, savedCards, businessInfo reactive stores
5051368d9b test: GDPR erasure — fix RetainsEditRequestNotes for anonymised requested_by, PreservesFinancialRows for HMRC audit fields, adversarial test cleanup
509b2d926d test: payment coverage — gift card daily caps, buildSplitRecords, ValidateAmount edge cases, SquareRefundStatusToLocal
4d179385e8 test: security regression — IDOR payment-check scoping, CORS preflight 403, rate limiter pruning, services error leakage
a358c8c0ea docs: README test count, Technical Manual default hours table, local-dev-2.sh config
Compare 188 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 18:22:57 +01:00
24af3a1fca fix: enable eslint-plugin-svelte a11y rules and fix violations
popertots pushed to main at popertots/Crussell 2026-07-11 18:11:54 +01:00
6777fb9b97 fix: remove heavy linters from pre-commit (golangci-lint, staticcheck, gosec) — CI-only
popertots pushed to main at popertots/Crussell 2026-07-11 18:07:06 +01:00
bbbffce20d fix: gocritic linter issues (appendAssign, ifElseChain, regexpMust)
popertots pushed to main at popertots/Crussell 2026-07-11 17:57:49 +01:00
35bc021857 fix: replace err.Error() string match with errors.Is(err, pgx.ErrTxClosed)
5d9fa1178b fix: replace silent json.Encode with error-logging pattern across all handlers
Compare 2 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 17:50:24 +01:00
0bef0f7973 fix: remove redundant rollback, document asymmetry in cancellation notifications
popertots pushed to main at popertots/Crussell 2026-07-11 17:46:18 +01:00
0edc111bfe fix: correct global milestone discount indentation (C1)
popertots pushed to main at popertots/Crussell 2026-07-11 17:44:19 +01:00
8ae592d0c5 fix: add golangci config, restore CI timeouts, svelte-check warnings, RespondError helper
b864873310 fix: include SquarePaymentID in commit-failure log for manual reconciliation
Compare 2 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 17:15:03 +01:00
11fbf869e1 fix: add 30s timeouts to account.go goroutines using context.Background()
0afa642a10 fix: add 60% coverage minimum to CI, scope prettier to staged frontend files
Compare 2 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 16:41:33 +01:00
7d6cb0c375 fix: prettier formatting on EditRequestModal.svelte
d6a3e30503 fix: compare notification IDs instead of timestamps in upsert test
Compare 2 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 16:20:44 +01:00
c8051a76d6 fix: replace time.Sleep with poll loops in tests, fix a11y target=_blank violations
0c1fc2b819 fix: log internal errors server-side, add timeout to GDPR goroutine
05c5d73d30 fix: add ShouldFail to Square MockClient for testing payment error paths
ce0bb43ebf fix: auth and ratelimit middleware return JSON errors instead of text/plain
e4a56ab04d fix: add defer tx.Rollback to CreateTipPayment to prevent transaction leak
Compare 5 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 15:42:44 +01:00
8b911d788c ci: trigger fresh pipeline after Docker prune setup
popertots pushed to main at popertots/Crussell 2026-07-11 15:29:45 +01:00
b3729c8a5a docs: add DAV_SKIP_INIT to .env.example
a3243fab27 fix: auto-set DAV_SKIP_INIT=1 in test init to match local GO_TESTING behavior
Compare 2 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 15:10:41 +01:00
4d87bf791f fix: replace GO_TESTING with DAV_SKIP_INIT for DAV service initialization
popertots pushed to main at popertots/Crussell 2026-07-11 15:09:23 +01:00
f147be0b99 fix: add error logging to remaining nolint:errcheck scan sites for observability
ad15127777 fix: remove nonDepositPaymentType dead code, wire dead handlers to routes
Compare 2 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 15:03:09 +01:00
df325487cf fix: gift card admin notification uses NULL booking_id (not cardID), use tx not db.Conn
popertots pushed to main at popertots/Crussell 2026-07-11 14:46:18 +01:00
ac104e19c5 fix: remove rate limiter dev stub, consolidate tests under all build tags
9b235a1298 fix: add error logging to 3 non-aggregate nolint:errcheck sites (duration lookup, deposit-paid scans)
d410dce0e0 fix: gift card friend purchase notifies admin, frontend no longer falsely claims email sent
9f9f0eed98 fix: add error logging to discount campaign payment/times_redeemed execs
7a51bcc49a fix: JTI revocation returns error, LogoutHandler returns 500 on failure
Compare 5 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 14:18:08 +01:00
9e85bc766b docs: update obsidian docs — test count, coverage, a11y, limitations
428e250b4f docs: update README test count and add pre-commit hook section
85c043ad7f fix: add golangci-lint to pre-commit hook, clarify R2_ENDPOINT in env example
Compare 3 commits »
popertots pushed to main at popertots/Crussell 2026-07-11 13:34:10 +01:00
b549014a68 fix: add nolint:errcheck to AdminGetInProgressBookingHandler json.Encode
popertots pushed to main at popertots/Crussell 2026-07-11 13:27:28 +01:00
28620f69a5 fix: restore dead functions properly, match test expectations, fix vet/lint