350 Commits

Include renames

Author	SHA1	Message	Date
popertots	28f0ddb328	Fix tip amount-change false dedup, wire BuyerEmail everywhere, clear ESLint errors ... Money-moving fixes: - Tip idempotency key regenerates when the tip amount changes after a failed attempt (all 3 tip flows). Cached key still reused on same-amount retry (dedup intact) and cleared on success/modal reset. Prevents silent under-charge when a user retries at a different amount. - Till replay path returns actual till_sales.status (may be 'pending') instead of hardcoded 'completed' — no more misreported successful charge. - BuyerEmail wired for CreateBookingPayment, gift card purchases, and till sales (saved_card + online_square), matching the tip flow. Email lookup errors logged, non-fatal. - Till buyer-email errors now logged (was silently swallowed). - on_the_house till top-up uses cached getIdempotencyKey() for retry-safe dedup (was fresh crypto.randomUUID()). Test/validation fixes: - Add TestPaymentFromSquare_* unit tests (else-branch + nil card details), build tag relaxed to 'test' so they run in the standard dev suite. - Add TestValidateCardInfo table test (7 cases: both/either/neither/empty). - Add TestCreateTillSale_TwoIdenticalCreateSales_BothSucceed regression test. - Remove dead mock pre-registration in TestTipPayment_WithSavedCard. - Correct misleading till regression-test comment. ESLint cleanup (12 errors -> 0): - Remove unused loadingCards in tip + pay-tip pages (dead assignments in loadSavedCards). - Scoped eslint-disable for {@html} in CardBrandIcon (hardcoded brand SVGs). - Remove dead confirmSaveDefaultHours + unused rescheduleVersion prop in WeeklySchedule (and its parent pass-through). - Replace new Date() with SvelteDate in WeeklySchedule + BusinessHours. - Fix each-block key in BusinessHours skeleton loader. - Use void expression for reactivity-tracker reads in effects.	2026-08-22 00:34:49 +01:00
popertots	a4441b6acf	Fix review findings: till idempotency keys, sha256 card key, paymentFromSquare fallback, regression test ... till.go: - Replace deterministicTillKey (request-field hash) with uniqueTillKey (crypto/rand.Text) - Deterministic hashes broke legitimate identical create sales (empty gift_card_id collides on till_sales idempotency_key UNIQUE constraint → 500 on second sale) - Client-supplied keys handle dedup; fallback only needs uniqueness - Use rand.Text() (Go 1.24+) instead of deprecated rand.Read with dead error check till_test.go: - Add TestCreateTillSale_TwoIdenticalCreateSales_BothSucceed regression test (two identical keyless cash creates must both return 201) square_http_client.go: - createCardOnFileHTTP: replace reversible hex encoding with crypto/sha256 - paymentFromSquare: replace dead-code fallback with reachable else branch - Remove unused url import cleanup where applicable	2026-08-22 00:34:49 +01:00
popertots	2459ddc919	Fix review findings: expiry bug (all 8 files), idempotency keys, card_expiry/card_cvc removal, URL encoding, BuyerEmail logging, ValidateCardInfo, saved-card test, future work doc ... Backend: - Fix refund idempotency key: clock.Now() → deterministic (pr.ID + amount) - Fix ValidateCardInfo: enforce mutual exclusivity, handle empty strings symmetrically - Fix paymentFromSquare brand fallback (remove dead SourceType fallback) - Fix URL encoding: PathEscape → QueryEscape for customer_id query param - Fix BuyerEmail: log warning on DB error instead of silent discard - Fix idempotency key in createCardOnFileHTTP: time.Now() → deterministic hex hash - Add BuyerEmail to CreateTipPayment Square request - Move realBaseURL from shared file to square_dev.go (only used in dev) - Add TestTipPayment_WithSavedCard test (card_id path coverage) - Fix AMEX brand in mock (AMEX → AMERICAN_EXPRESS, fix test) Frontend: - Fix off-by-month expiry bug in ALL 8 files using year-month arithmetic (parseExpiryParts returns 1-indexed, SvelteDate expects 0-indexed) Files: tip/+page, pay-tip/[id], UserBookingModal, UserPaymentModal, BookingFlow, account/+page (add card + buy gift card sections) - Remove card_expiry/card_cvc from tip request bodies (backend has no fields) Docs: - Mark P9 (placeholder tokens) as completed, add P11 (Square Web Payments SDK) - Mark T13 (rune arithmetic) as completed	2026-08-22 00:34:49 +01:00
popertots	4abcb324c9	Square payment integration: real HTTP client, tip flow rewrite, card UI/validation overhaul ... Backend: - Create square_http_client.go: real Square REST API client (Payments, Terminal Checkouts, Refunds, Cards, Locations) with proper JSON types, auth, error handling - Update ProdClient in square.go to delegate to shared HTTP functions - Wire devProdClient in square_dev.go to also make real HTTP calls for sandbox/prod env - Rewrite CreateTipPayment handler: accept card_id OR new_card_token (+save_card), advisory lock, idempotency check, max amount validation - Add ValidateCardInfo, bump ValidateAmount max to £10,000 - Fix mock CreateCardOnFile to detect brand/last4 from raw card numbers - Fix mock RefundPayment to index by SquarePayID and accept unknown payment IDs - Remove dead types (ProcessingFee, sqAddress), add Deadline parity - Fix AMEX brand inconsistency (AMEX -> AMERICAN_EXPRESS) - Pre-existing fix: remove unused context import in giftcards.go Frontend: - CardInput.svelte: add onfieldblur/onfieldinput callbacks for blur-based validation - CardBrandIcon.svelte: brand SVGs for VISA, MC, AMEX, Discover, Diners, JCB, Square Gift Card, UnionPay, Interac, EFTPOS - tip/+page, pay-tip/[id], UserBookingModal tip: saved card list + CardInput + Luhn/expiry/CVC validation + blur-based errors + no-saved-cards edge case - UserPaymentModal, BookingFlow: card validation parity (blur-based, all-valid check) - account page: replace text brand badges with CardBrandIcon - Fix handleCustomTip bug (state mutations outside if block) - Remove dead pageState variable - Add tip modal scroll (max-h-[90vh] overflow-y-auto) - Submit button disabled on !isCardValid Tests: - 30 square package tests (+new: CreateCardOnFile raw number path, detectCardInfo variants) - 5 tip handler tests (HappyPath, NoPriorPayment, WrongOwner, MultipleTips, TxFailure) - All +-race clean, refund tests fixed	2026-08-22 00:34:49 +01:00
popertots	df4c9afeb9	fix: remove admin notification for friend gift card purchase ... Admin no longer receives a notification when someone buys a gift card for a friend. The recipient email and gift code are logged for future SMTP delivery instead.	2026-08-22 00:34:49 +01:00
popertots	aad364bbd1	fix: order zero-booking services after popular ones (NULLS LAST) ... PostgreSQL ORDER BY ... DESC puts NULLs first by default, so services with no bookings appeared at the top instead of the bottom. Also removes the booking count column from SELECT entirely — the sort is done purely in the ORDER BY.	2026-08-22 00:34:49 +01:00
popertots	3c0c4dd962	feat: sort price list by booking popularity over last 6 months ... Adds GET /api/services/popular endpoint that returns services sorted by booking count (desc) then price (desc) for ties. Prices page now fetches from this endpoint instead of the default alphabetical sort.	2026-08-22 00:34:49 +01:00
popertots	1fb84b8998	test: add hours validation tests for edit request handler ... Add TestRequestEditHandler_PastClosing_Blocked (19:30 extends past 20:00 closing), TestRequestEditHandler_StagedHoursClosed_Blocked (day closed under staged change), and TestRequestEditHandler_ValidTime_Succeeds (10:00 within open hours). Removed the closed-day test that was incompatible with the bookings test DB seed (all 7 days open 08:00-20:00) — that case is covered by the staged-hours test.	2026-08-22 00:34:49 +01:00
popertots	991f3af540	fix: add hours validation to user edit requests (was M8/L5 stubs) ... RequestEditHandler had empty M8/L5 placeholder comments where hours validation was planned. Implemented full validation: staged-hours-aware closing time check via getClosingTimeForDate, closed-day check, and closing-hours boundary check using the booking's total_duration_minutes. Removed placeholder comments. Updated test to propose an open-day time that doesn't extend past closing.	2026-08-22 00:34:49 +01:00
popertots	c80ad467e7	fix: add staged hours check to edit request approval ... AdminApproveEditRequestHandler checked exceptional hours but not staged default hours changes. Added getClosingTimeForDate check for the proposed reschedule time, matching the pattern used in AdminRescheduleBookingHandler.	2026-08-22 00:34:49 +01:00
popertots	503449b0bc	fix: staged hours no longer leak closed values to days before effective date ... The else-if chain in GetWorkingHours/computeAvailableHours entered the staged change block for ALL days when a pending change existed, but only applied hours for future dates — leaving earlier days as zero-value (closed). Moved the effective date check into the else-if condition so early days fall through to default hours.	2026-08-22 00:34:49 +01:00
popertots	a6cb803ff2	test: fix today_test flakiness with London-timezone-aware booking times ... Replace clock.Now() with fixed London-timezone times in TestGetCurrentNext_WithMultipleDataPoints to prevent near-midnight UTC failures where bookings fall outside the London 'today' window.	2026-08-22 00:34:49 +01:00
popertots	70613497b4	feat: add daily cron to apply scheduled default hours changes ... Add ApplyScheduledDefaultHours which checks default_hours_scheduled_changes at midnight, bulk-updates working_hours with staged values, and inserts an admin_notification. Register as the 'apply-default-hours' job in the scheduler (daily at 00:05).	2026-08-22 00:34:49 +01:00
popertots	d0f233ae70	test: add tests for staged default hours change handlers ... Add tests for ScheduleDefaultHoursChange, GetScheduledDefaultHoursChange, CancelScheduledDefaultHoursChange, GetDefaultHoursConflictingBookings, and GetWorkingHours/GetDefaultHours integration with staged changes.	2026-08-22 00:34:49 +01:00
popertots	2a840bb7e6	feat: add staged default hours change handlers with conflict detection ... Add ScheduleDefaultHoursChange, GetScheduledDefaultHoursChange, CancelScheduledDefaultHoursChange, and GetDefaultHoursConflictingBookings handlers. Updates GetDefaultHours to return { current, scheduled_change }. Updates GetWorkingHours and computeAvailableHours to apply staged hours for dates on/after the effective_date.	2026-08-22 00:34:48 +01:00
popertots	8f99b8b5c3	feat: check staged default hours in all booking creation paths ... Integrate getClosingTimeForDate into AdminReserveSlotHandler, CreateBookingHandler, AdminRescheduleBookingHandler, and AdminCreateBookingForUserHandler. Rejects bookings when the staged schedule marks a day as closed (00:00).	2026-08-22 00:34:48 +01:00
popertots	52caf1b7b5	feat: add getClosingTimeForDate to check staged default hours for bookings ... Add getClosingTimeForDate that queries default_hours_scheduled_changes for a pending staged change whose effective_date <= the booking date. Falls back to current working_hours if no staged change applies. Also checks the staged schedule to see if a weekday is closed (returns 00:00).	2026-08-22 00:34:48 +01:00
popertots	3eec71a56c	fix: sanitize API error text display and add time_blockers tests ... Add extractErrorMessage helper for JSON error body parsing and apply sanitizeText across all toast displays. Add time_blockers test coverage for new holiday placeholder cleanup and overlapping scenarios.	2026-08-22 00:34:48 +01:00
popertots	6567ff4904	fix: harden login validation with proper JSON error responses ... Change LoginHandler validation error from http.Error (plain text, mismatched Content-Type) to mw.RespondError (proper JSON {error:...} response). Add TestLogin_EmptyFields and TestLogin_MissingEmail tests verifying JSON error format.	2026-08-22 00:34:48 +01:00
popertots	5ed24f263a	fix: prevent internal error details leaking in HTTP responses ... Replace err.Error() concatenation in JSON decode error responses with fixed 'invalid request body' message across 5 locations in custom_services.go, discount_campaigns.go, and services.go.	2026-08-22 00:34:48 +01:00
popertots	291868f11a	test: add conflict detection and preview available hours tests ... Add 12 new tests for GetConflictingBookingsForExceptionHandler (closed day, within hours, before-opening, after-closing, multiple weeks, excluded statuses, invalid payload, wrong method) and GetPreviewAvailableHours (no proposed, proposed override, invalid JSON, missing params). Fix pre-existing test with FK violation (non-existent admin_id) by using fixture-created admin user.	2026-08-22 00:34:48 +01:00
popertots	e27db9202e	feat: add holiday hours conflict detection with shared scheduling core ... Extract computeAvailableHours as shared core between GetAvailableHours and GetPreviewAvailableHours, eliminating ~320 lines of duplication. Add GetConflictingBookingsForExceptionHandler (POST) for holiday hours conflict detection with batch service loading, int-based time comparison, and ActiveBookingStatuses constant. Add RESERVATION:placeholder cleanup (24h TTL). Fix scan error propagation in all scheduling row iterations. Add rows.Err() checks.	2026-08-22 00:34:48 +01:00
popertots	b5f215aaa4	fix: move preview-available-hours to admin route group ... Move GET /api/scheduling/preview-available-hours from public OptionalAuth group into the admin-only group (RequireAuth + RequireAdmin) since it's an admin simulation tool.	2026-08-22 00:34:48 +01:00
popertots	117c37eaff	feat: add contact-availability handler and route	2026-08-22 00:34:48 +01:00
popertots	bbbffce20d	fix: gocritic linter issues (appendAssign, ifElseChain, regexpMust)	2026-07-11 18:03:05 +01:00
popertotsandSisyphus	35bc021857	fix: replace err.Error() string match with errors.Is(err, pgx.ErrTxClosed) ... Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>	2026-07-11 17:53:29 +01:00
popertots	5d9fa1178b	fix: replace silent json.Encode with error-logging pattern across all handlers	2026-07-11 17:50:07 +01:00
popertots	0bef0f7973	fix: remove redundant rollback, document asymmetry in cancellation notifications	2026-07-11 17:45:24 +01:00
popertots	0edc111bfe	fix: correct global milestone discount indentation (C1)	2026-07-11 17:42:17 +01:00
popertots	8ae592d0c5	fix: add golangci config, restore CI timeouts, svelte-check warnings, RespondError helper	2026-07-11 17:38:50 +01:00
popertots	b864873310	fix: include SquarePaymentID in commit-failure log for manual reconciliation	2026-07-11 17:35:10 +01:00
popertots	11fbf869e1	fix: add 30s timeouts to account.go goroutines using context.Background()	2026-07-11 17:10:11 +01:00
popertots	0afa642a10	fix: add 60% coverage minimum to CI, scope prettier to staged frontend files	2026-07-11 17:09:37 +01:00
popertotsandSisyphus	d6a3e30503	fix: compare notification IDs instead of timestamps in upsert test ... The PoolProxy.Begin routes to the outer test transaction, so PG NOW() returns the same value for both handler invocations. Comparing notification IDs correctly verifies the notification was deleted and recreated. Also removes unused testify/assert import. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>	2026-07-11 16:25:33 +01:00
popertots	c8051a76d6	fix: replace time.Sleep with poll loops in tests, fix a11y target=_blank violations	2026-07-11 16:16:23 +01:00
popertots	0c1fc2b819	fix: log internal errors server-side, add timeout to GDPR goroutine	2026-07-11 16:09:11 +01:00
popertots	05c5d73d30	fix: add ShouldFail to Square MockClient for testing payment error paths	2026-07-11 16:07:05 +01:00
popertots	ce0bb43ebf	fix: auth and ratelimit middleware return JSON errors instead of text/plain	2026-07-11 16:05:56 +01:00
popertots	e4a56ab04d	fix: add defer tx.Rollback to CreateTipPayment to prevent transaction leak	2026-07-11 16:04:48 +01:00
popertotsandSisyphus	a3243fab27	fix: auto-set DAV_SKIP_INIT=1 in test init to match local GO_TESTING behavior ... The DAV_SKIP_INIT env var was only set in CI, not locally. db_test_init.go always auto-sets GO_TESTING=1 for local runs — now does the same for DAV_SKIP_INIT, so tests don't panic on DAV init failure. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>	2026-07-11 15:13:51 +01:00
popertots	4d87bf791f	fix: replace GO_TESTING with DAV_SKIP_INIT for DAV service initialization	2026-07-11 15:06:16 +01:00
popertots	f147be0b99	fix: add error logging to remaining nolint:errcheck scan sites for observability	2026-07-11 15:04:53 +01:00
popertots	ad15127777	fix: remove nonDepositPaymentType dead code, wire dead handlers to routes	2026-07-11 15:01:26 +01:00
popertots	df325487cf	fix: gift card admin notification uses NULL booking_id (not cardID), use tx not db.Conn	2026-07-11 14:59:09 +01:00
popertots	ac104e19c5	fix: remove rate limiter dev stub, consolidate tests under all build tags	2026-07-11 14:41:58 +01:00
popertots	9b235a1298	fix: add error logging to 3 non-aggregate nolint:errcheck sites (duration lookup, deposit-paid scans)	2026-07-11 14:41:06 +01:00
popertots	d410dce0e0	fix: gift card friend purchase notifies admin, frontend no longer falsely claims email sent	2026-07-11 14:39:54 +01:00
popertots	9f9f0eed98	fix: add error logging to discount campaign payment/times_redeemed execs	2026-07-11 14:37:47 +01:00
popertots	7a51bcc49a	fix: JTI revocation returns error, LogoutHandler returns 500 on failure	2026-07-11 14:35:34 +01:00
popertots	b549014a68	fix: add nolint:errcheck to AdminGetInProgressBookingHandler json.Encode	2026-07-11 13:30:09 +01:00