Commit Graph
515 Commits
Author SHA1 Message Date
popertotsandSisyphus d8dfad2b32 ci: add Go and npm dependency caching via actions/cache
CI / Go vulnerabilities (push) Successful in 58s
CI / Tests (push) Successful in 1m53s
CI / Frontend lint & types (push) Successful in 2m12s
CI / Race detector (push) Successful in 3m59s
Add actions/cache@v4 to all four CI jobs. Go module cache (go/pkg/mod + go-build) keyed on go.sum for test, race, and vulns jobs. npm cache (~/.npm + node_modules) keyed on package-lock.json for frontend job. Cuts dependency download time to near-zero on cache hit.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 20:37:59 +01:00
popertotsandSisyphus 1c1fc6a921 docs: update README and obsidian docs with reservation improvements
CI / Go vulnerabilities (push) Successful in 34s
CI / Tests (push) Successful in 1m20s
CI / Frontend lint & types (push) Successful in 1m42s
CI / Race detector (push) Successful in 3m33s
Document self-blocking prevention (excludeUserID), explicit reservation cancellation endpoint, background cleanup goroutine, and edit_request reservation scrubbing. Bump test counts from 1,169 to 1,180 and package count from 19 to 20. Add race detector command to README.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 20:26:47 +01:00
popertotsandSisyphus be22710f7b test: add scheduling excludeUserID integration test
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 20:26:40 +01:00
popertotsandSisyphus 2e0760f083 feat: add IP-based anon reservation cleanup to admin reserve handler
Extend AdminReserveSlotHandler's pre-overlap DELETE to also clean up anonymous RESERVATION:anon entries matching the admin's IP address. This handles the edge case where an admin previously reserved a slot without authentication. Also reorganise imports to follow goimports conventions.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 20:26:33 +01:00
popertotsandSisyphus cc6ad7f00f fix: remove t.Parallel from VAT lifecycle test
CI / Go vulnerabilities (push) Successful in 33s
CI / Tests (push) Successful in 1m28s
CI / Frontend lint & types (push) Successful in 1m45s
CI / Race detector (push) Successful in 3m28s
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 20:08:12 +01:00
popertotsandSisyphus 30c9012562 fix: move dav.Service init from auth_test to user testmain
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 20:08:09 +01:00
popertotsandSisyphus 4879ca5a82 style: format multi-line expressions in BookingFlow.svelte
CI / Go vulnerabilities (push) Successful in 31s
CI / Frontend lint & types (push) Successful in 1m42s
CI / Tests (push) Failing after 1m52s
CI / Race detector (push) Failing after 4m3s
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 12:00:09 +01:00
popertotsandSisyphus e642b0fa3e fix: move BookingFlow window type to app.d.ts and fix authHeaders typing
CI / Go vulnerabilities (push) Successful in 34s
CI / Frontend lint & types (push) Failing after 1m11s
CI / Tests (push) Successful in 2m4s
CI / Race detector (push) Failing after 4m8s
Move __bookingFlowCountdownInterval from inline declare global in BookingFlow.svelte to global app.d.ts. Fix authHeaders type from {} to undefined to satisfy TypeScript.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 11:55:45 +01:00
popertotsandSisyphus 69ae3e1f99 chore: bump golang.org/x/image from v0.42.0 to v0.43.0
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 11:55:39 +01:00
popertotsandSisyphus 2069a99f8c feat: improve booking flow with auth headers and reservation release
CI / Go vulnerabilities (push) Failing after 42s
CI / Frontend lint & types (push) Failing after 59s
CI / Tests (push) Successful in 1m27s
CI / Race detector (push) Failing after 3m35s
Send auth token in reserve/availability/working-hours requests so the backend can exclude the user's own reservations. Cancel old reservation via DELETE before reserving a new slot. Track reserved slot time/date for back-navigate detection. Clean up countdown interval via onDestroy and window reference to prevent duplicates.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 11:48:14 +01:00
popertotsandSisyphus 296a67770e fix: resolve RLock deadlock in Square mock client
Move m.mu.RUnlock to defer in GetCheckout and remove duplicate RLock/RUnlock around m.completed lookup. This prevents a deadlock when CheckoutPending error is returned but the RLock was already released.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 11:48:04 +01:00
popertotsandSisyphus 33c945159c feat: add cancel reservation handler and background cleanup
Add CancelReservationHandler (DELETE /api/bookings/reserve) to release authenticated user's active reservation. Register route in main.go. Add background goroutine for periodic reservation cleanup using CleanupOldReservations. Add idx_time_blockers_created_at index and extend anon cleanup to cover edit_request reservations in init-script.sql.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 11:47:54 +01:00
popertotsandSisyphus 2386bd0ca2 test: add tests for reservation self-block prevention
Add TestReserveSlot_DoesNotSelfBlock, TestAdminReserveSlot_DoesNotSelfBlock and TestReserveSlot_CleansUpAnonReservation. Add UserIDKey context to admin approve edit request tests. Remove weekend-day adjustment in TestAdminApproveEditRequest_OverlapWithBooking_Regression and TestAdminApproveEditRequest_EvictsPendingRelease (no longer needed).

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 11:47:43 +01:00
popertotsandSisyphus c1a9f35ea5 feat: prevent reservation self-block in booking handlers
Pass excludeUserID to CheckTimeBlockerOverlap in AdminReserveSlotHandler, CreateBookingHandler, EditBookingHandler, AdminRescheduleBookingHandler, AdminCreateBookingForUserHandler, AdminApproveEditRequestHandler, and ReserveSlotHandler. Also clean up stale reservations before overlap check in AdminReserveSlotHandler and ReserveSlotHandler via db.Conn.Exec for cross-connection visibility. Improve error handling in RequestEditHandler's service update block.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 11:45:02 +01:00
popertotsandSisyphus 920eb761fd feat: add excludeUserID param to scheduling time blockers
Add optional excludeUserID parameter to GetTimeBlockersInRange and CheckTimeBlockerOverlap so a user's own RESERVATION entries are excluded from overlap checks. This prevents users from self-blocking on their existing reservation when checking availability or confirming a booking.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-05 11:44:52 +01:00
popertots a00ed3c283 ci: re-add test and race jobs alongside lint and vulns
CI / Go vulnerabilities (push) Successful in 36s
CI / Tests (push) Successful in 1m34s
CI / Frontend lint & types (push) Successful in 1m41s
CI / Race detector (push) Failing after 3m30s
2026-06-25 19:39:09 +01:00
popertots 34147f87ab fix: add inline eslint-disable inside handleGotoAccount function
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Successful in 1m6s
2026-06-25 18:55:39 +01:00
popertots 234c1d20b7 style: fix prettier formatting in gdpr page
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 22s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m6s
2026-06-25 18:54:16 +01:00
popertots eb9a9186c3 fix: use function wrapper for goto() calls to suppress eslint rule in template
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 26s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 40s
2026-06-25 18:51:22 +01:00
popertots 633d8ff1a8 fix: eslint-disable comments correctly placed for script and template sections
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m4s
2026-06-25 18:44:05 +01:00
popertots 61338921e8 fix: resolve all lint issues — eslint, prettier, svelte-check pass
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m4s
2026-06-25 18:34:42 +01:00
popertots bce26dce2a fix: strip and re-add eslint-disable comments on correct lines, fix stray > in NavBar
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 22s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 29s
2026-06-25 18:19:19 +01:00
popertots 7bb017d6b4 fix: suppress pre-existing no-unused-vars in account page
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m5s
2026-06-25 18:09:03 +01:00
popertots 9627c86317 style: fix prettier formatting in account page
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 22s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m5s
2026-06-25 18:04:29 +01:00
popertots 106eef8468 fix: use JS comment format for eslint-disable inside script sections, remove duplicates
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 28s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 39s
2026-06-25 18:01:44 +01:00
popertots ac24d3f990 fix: reposition eslint-disable comments for goto() calls and any types
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 31s
2026-06-25 17:54:34 +01:00
popertots fc26f9524a style: exclude mapcn-svelte from prettier checks (third-party code)
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 22s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m4s
2026-06-25 17:48:04 +01:00
popertots 154a7217b4 fix: ignore third-party map component from linting
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 22s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 38s
The mapcn-svelte component at src/lib/components/ui/map/ is a
third-party library, not our code. Add to eslint ignores so we
don't need to maintain eslint-disable comments in imported code.
2026-06-25 17:43:15 +01:00
popertots ecf8c23c49 fix: add eslint-disable-next-line comments for map DOM manipulation
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 38s
2026-06-25 17:38:20 +01:00
popertots a5812018d8 style: fix prettier formatting in 3 files
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m6s
2026-06-25 17:28:42 +01:00
popertots 74a24c3ef1 fix: resolve remaining eslint errors — svelte-check, prettier, eslint all pass
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 38s
2026-06-25 17:24:07 +01:00
popertots 4b5d85b0b9 style: fix self-closing div tags in BookingFlow.svelte
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 22s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m9s
2026-06-25 17:17:20 +01:00
popertots bc7558cd39 style: run prettier format on 9 files
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 22s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 1m11s
2026-06-25 17:17:01 +01:00
popertots eb15a399ef fix: resolve all agent-induced errors — svelte-check, eslint, prettier pass
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 24s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 40s
- Fix <!-- svelte-ignore HTML comments in script sections (invalid JS)
- Fix catch err -> _err references across all files after renames
- Fix .writable (not in Svelte 5 stable) back to +
- Fix NavBar dynamic href links with proper eslint-disable in template
- Fix SvelteMap type params missing after Map->SvelteMap conversion
- Fix required->_required and onclose->_onclose prop mismatches
- Fix HolidayHours inline type mismatch, BookingCreateModal suppression
- Fix remaining pre-existing no-unused-vars with eslint-disable-next-line
- Revert fonts commit, run prettier format

svelte-check: 0 errors, eslint: 0 errors, prettier: clean
2026-06-25 17:10:49 +01:00
popertots e0f22e5c5c fix: revert agent damage — fix svelte-ignore comments, catch var refs, prop mismatches
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 23s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 30s
- Convert HTML comments in script sections to eslint-disable-next-line
- Fix err->_err references in catch blocks across 8 files
- Fix required→_required and onclose→_onclose prop mismatches
- Revert BookingCreateModal.svelte from no-unused-vars agent damage
- Fix broken regex in account page
- Fix .writable (not in Svelte 5 stable) back to +
- Fix NavBar dynamic href links with proper eslint-disable
2026-06-25 16:50:23 +01:00
popertots 82e6f75354 ci: split govulncheck and frontend checks into parallel jobs
Lint & Vuln Scan / Go vulnerabilities (push) Successful in 22s
Lint & Vuln Scan / Frontend lint & types (push) Failing after 30s
2026-06-25 16:41:18 +01:00
popertots 7c56d6cfb7 fix: rename required to _required in PhoneInput props to match destructuring
Frontend Lint & Vulns / Lint & vulns (push) Failing after 44s
2026-06-25 15:12:16 +01:00
popertots a099f84d1b style: fix no-unused-vars -- prefix unused catch bindings, remove dead code, suppress template-use false positives 2026-06-25 15:10:07 +01:00
popertots f3436ac37a style: fix no-navigation-without-resolve — add resolve() for SPA links, rel=external for target=_blank, suppress in event handlers and effects 2026-06-25 14:59:38 +01:00
popertots df66041b7c style: suppress no-dom-manipulating — Maplibre GL integration requires imperative DOM 2026-06-25 14:47:49 +01:00
popertots a8d04b77e2 style: fix no-explicit-any — replace with proper TypeScript types 2026-06-25 14:46:51 +01:00
popertots 6291d04b47 style: fix no-unused-props -- remove genuinely unused prop type fields from component interfaces 2026-06-25 14:44:10 +01:00
popertots 111baa27f9 style: fix require-each-key — add missing keys to all {#each} blocks 2026-06-25 14:42:19 +01:00
popertots 334b911e16 style: fix prefer-svelte-reactivity — replace with Svelte reactive equivalents 2026-06-25 14:40:22 +01:00
popertots d5e93b3be2 style: fix valid-prop-names-in-kit-pages — use $page store instead of export let props in +error.svelte 2026-06-25 14:36:08 +01:00
popertots 7514a228d5 style: fix prefer-writable-derived — use $derived.writable instead of $state+$effect sync 2026-06-25 14:35:17 +01:00
popertots 8a339b7810 style: fix no-unnecessary-state-wrap — SvelteDate is already reactive, remove redundant $state() 2026-06-25 14:34:25 +01:00
popertots 63e9b32720 style: fix no-empty — add comments to intentionally empty catch blocks 2026-06-25 14:33:44 +01:00
popertots 7abacbc2b4 style: fix no-useless-escape — remove unnecessary backslashes in regex char classes 2026-06-25 14:32:53 +01:00
popertots 0dff41a4ee style: fix svelte/no-useless-mustaches — unwrap string literals from mustache expressions 2026-06-25 14:31:49 +01:00