Commit Graph
433 Commits
Author SHA1 Message Date
popertots 3eec71a56c fix: sanitize API error text display and add time_blockers tests
Add extractErrorMessage helper for JSON error body parsing and apply sanitizeText across all toast displays. Add time_blockers test coverage for new holiday placeholder cleanup and overlapping scenarios.
2026-08-22 00:34:48 +01:00
popertots 6567ff4904 fix: harden login validation with proper JSON error responses
Change LoginHandler validation error from http.Error (plain text, mismatched Content-Type) to mw.RespondError (proper JSON {error:...} response). Add TestLogin_EmptyFields and TestLogin_MissingEmail tests verifying JSON error format.
2026-08-22 00:34:48 +01:00
popertots 5ed24f263a fix: prevent internal error details leaking in HTTP responses
Replace err.Error() concatenation in JSON decode error responses with fixed 'invalid request body' message across 5 locations in custom_services.go, discount_campaigns.go, and services.go.
2026-08-22 00:34:48 +01:00
popertots 291868f11a test: add conflict detection and preview available hours tests
Add 12 new tests for GetConflictingBookingsForExceptionHandler (closed day, within hours, before-opening, after-closing, multiple weeks, excluded statuses, invalid payload, wrong method) and GetPreviewAvailableHours (no proposed, proposed override, invalid JSON, missing params). Fix pre-existing test with FK violation (non-existent admin_id) by using fixture-created admin user.
2026-08-22 00:34:48 +01:00
popertots e27db9202e feat: add holiday hours conflict detection with shared scheduling core
Extract computeAvailableHours as shared core between GetAvailableHours and GetPreviewAvailableHours, eliminating ~320 lines of duplication. Add GetConflictingBookingsForExceptionHandler (POST) for holiday hours conflict detection with batch service loading, int-based time comparison, and ActiveBookingStatuses constant. Add RESERVATION:placeholder cleanup (24h TTL). Fix scan error propagation in all scheduling row iterations. Add rows.Err() checks.
2026-08-22 00:34:48 +01:00
popertots b5f215aaa4 fix: move preview-available-hours to admin route group
Move GET /api/scheduling/preview-available-hours from public OptionalAuth group into the admin-only group (RequireAuth + RequireAdmin) since it's an admin simulation tool.
2026-08-22 00:34:48 +01:00
popertots 117c37eaff feat: add contact-availability handler and route 2026-08-22 00:34:48 +01:00
popertots bbbffce20d fix: gocritic linter issues (appendAssign, ifElseChain, regexpMust)
CI / Docker compose check (push) Successful in 51s
CI / Env docs check (push) Successful in 52s
CI / Frontend deps check (push) Successful in 54s
CI / Frontend major deps (push) Successful in 53s
CI / Secrets scan (push) Successful in 55s
CI / Nginx config check (push) Successful in 57s
CI / Go build (push) Successful in 1m0s
CI / Frontend build (push) Successful in 1m4s
CI / Knip (push) Successful in 58s
CI / Go vet (dev) (push) Successful in 1m45s
CI / Frontend a11y check (push) Successful in 2m8s
CI / Go vet (prod) (push) Successful in 2m17s
CI / go mod tidy (push) Successful in 36s
CI / Frontend QC (audit) (push) Successful in 47s
CI / Staticcheck (prod) (push) Successful in 3m15s
CI / Go vulnerabilities (push) Successful in 1m22s
CI / golangci-lint (push) Has been cancelled
CI / Staticcheck (dev) (push) Has been cancelled
CI / Security scan (dev) (push) Has been cancelled
CI / Security scan (prod) (push) Has been cancelled
CI / Tests (prod) (push) Has been cancelled
CI / Tests (dev) (push) Has been cancelled
CI / Race (prod) (push) Has been cancelled
CI / Race (dev) (push) Has been cancelled
CI / Svelte strict check (push) Has been cancelled
CI / Frontend QC (typecheck) (push) Has been cancelled
CI / Frontend QC (lint) (push) Has been cancelled
2026-07-11 18:03:05 +01:00
popertotsandSisyphus 35bc021857 fix: replace err.Error() string match with errors.Is(err, pgx.ErrTxClosed)
CI / Env docs check (push) Successful in 25s
CI / Docker compose check (push) Successful in 24s
CI / Frontend deps check (push) Successful in 30s
CI / Frontend major deps (push) Successful in 33s
CI / Nginx config check (push) Successful in 59s
CI / Go build (push) Successful in 1m15s
CI / Secrets scan (push) Successful in 1m16s
CI / Knip (push) Successful in 56s
CI / Frontend a11y check (push) Successful in 55s
CI / Frontend build (push) Successful in 1m27s
CI / go mod tidy (push) Successful in 17s
CI / Go vulnerabilities (push) Successful in 2m17s
CI / Go vet (prod) (push) Successful in 2m46s
CI / Go vet (dev) (push) Successful in 2m50s
CI / Staticcheck (prod) (push) Successful in 2m55s
CI / Staticcheck (dev) (push) Successful in 3m13s
CI / Frontend QC (audit) (push) Successful in 41s
CI / golangci-lint (push) Failing after 3m37s
CI / Frontend QC (typecheck) (push) Successful in 1m30s
CI / Frontend QC (lint) (push) Successful in 2m4s
CI / Security scan (prod) (push) Successful in 4m43s
CI / Security scan (dev) (push) Successful in 4m44s
CI / Tests (prod) (push) Has been skipped
CI / Tests (dev) (push) Has been skipped
CI / Race (prod) (push) Has been skipped
CI / Race (dev) (push) Has been skipped
CI / Svelte strict check (push) Successful in 33s
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-11 17:53:29 +01:00
popertots 5d9fa1178b fix: replace silent json.Encode with error-logging pattern across all handlers 2026-07-11 17:50:07 +01:00
popertots 0bef0f7973 fix: remove redundant rollback, document asymmetry in cancellation notifications
CI / Go build (push) Successful in 1m42s
CI / Secrets scan (push) Successful in 1m56s
CI / Env docs check (push) Successful in 1m55s
CI / Frontend major deps (push) Successful in 2m6s
CI / Frontend deps check (push) Successful in 1m30s
CI / Nginx config check (push) Successful in 2m48s
CI / Docker compose check (push) Successful in 2m50s
CI / Frontend build (push) Successful in 3m7s
CI / Go vet (dev) (push) Successful in 1m14s
CI / go mod tidy (push) Successful in 33s
CI / Knip (push) Successful in 1m15s
CI / Go vulnerabilities (push) Successful in 1m46s
CI / Frontend QC (audit) (push) Successful in 46s
CI / Staticcheck (prod) (push) Successful in 3m36s
CI / Frontend a11y check (push) Successful in 2m17s
CI / Staticcheck (dev) (push) Successful in 3m51s
CI / golangci-lint (push) Failing after 4m8s
CI / Frontend QC (typecheck) (push) Successful in 1m25s
CI / Go vet (prod) (push) Has been cancelled
CI / Security scan (dev) (push) Has been cancelled
CI / Security scan (prod) (push) Has been cancelled
CI / Tests (prod) (push) Has been cancelled
CI / Tests (dev) (push) Has been cancelled
CI / Race (prod) (push) Has been cancelled
CI / Race (dev) (push) Has been cancelled
CI / Svelte strict check (push) Has been cancelled
CI / Frontend QC (lint) (push) Has been cancelled
2026-07-11 17:45:24 +01:00
popertots 0edc111bfe fix: correct global milestone discount indentation (C1)
CI / Env docs check (push) Successful in 20s
CI / Docker compose check (push) Successful in 23s
CI / Nginx config check (push) Successful in 24s
CI / Frontend major deps (push) Successful in 35s
CI / Frontend deps check (push) Successful in 36s
CI / Secrets scan (push) Successful in 48s
CI / Go build (push) Successful in 45s
CI / Frontend build (push) Successful in 47s
CI / Knip (push) Successful in 55s
CI / Go vet (prod) (push) Successful in 1m39s
CI / Frontend a11y check (push) Successful in 2m7s
CI / Go vet (dev) (push) Successful in 2m6s
CI / go mod tidy (push) Successful in 32s
CI / golangci-lint (push) Has been cancelled
CI / Staticcheck (dev) (push) Has been cancelled
CI / Staticcheck (prod) (push) Has been cancelled
CI / Security scan (dev) (push) Has been cancelled
CI / Security scan (prod) (push) Has been cancelled
CI / Tests (prod) (push) Has been cancelled
CI / Tests (dev) (push) Has been cancelled
CI / Race (prod) (push) Has been cancelled
CI / Race (dev) (push) Has been cancelled
CI / Go vulnerabilities (push) Has been cancelled
CI / Svelte strict check (push) Has been cancelled
CI / Frontend QC (audit) (push) Has been cancelled
CI / Frontend QC (typecheck) (push) Has been cancelled
CI / Frontend QC (lint) (push) Has been cancelled
2026-07-11 17:42:17 +01:00
popertots 8ae592d0c5 fix: add golangci config, restore CI timeouts, svelte-check warnings, RespondError helper
CI / Env docs check (push) Successful in 13s
CI / Nginx config check (push) Successful in 36s
CI / Frontend major deps (push) Successful in 37s
CI / Docker compose check (push) Successful in 38s
CI / Frontend deps check (push) Successful in 41s
CI / Secrets scan (push) Successful in 42s
CI / Go build (push) Successful in 42s
CI / Frontend build (push) Successful in 49s
CI / go mod tidy (push) Successful in 26s
CI / Go vet (dev) (push) Has been cancelled
CI / Go vet (prod) (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
CI / Staticcheck (dev) (push) Has been cancelled
CI / Staticcheck (prod) (push) Has been cancelled
CI / Security scan (dev) (push) Has been cancelled
CI / Security scan (prod) (push) Has been cancelled
CI / Tests (prod) (push) Has been cancelled
CI / Tests (dev) (push) Has been cancelled
CI / Race (prod) (push) Has been cancelled
CI / Race (dev) (push) Has been cancelled
CI / Go vulnerabilities (push) Has been cancelled
CI / Knip (push) Has been cancelled
CI / Frontend a11y check (push) Has been cancelled
CI / Svelte strict check (push) Has been cancelled
CI / Frontend QC (audit) (push) Has been cancelled
CI / Frontend QC (typecheck) (push) Has been cancelled
CI / Frontend QC (lint) (push) Has been cancelled
2026-07-11 17:38:50 +01:00
popertots b864873310 fix: include SquarePaymentID in commit-failure log for manual reconciliation 2026-07-11 17:35:10 +01:00
popertots 11fbf869e1 fix: add 30s timeouts to account.go goroutines using context.Background()
CI / Env docs check (push) Successful in 13s
CI / Nginx config check (push) Successful in 20s
CI / Docker compose check (push) Successful in 20s
CI / Frontend major deps (push) Successful in 22s
CI / Frontend deps check (push) Successful in 28s
CI / Secrets scan (push) Successful in 41s
CI / Go build (push) Successful in 40s
CI / Frontend build (push) Successful in 43s
CI / Knip (push) Successful in 46s
CI / Go vet (prod) (push) Successful in 1m45s
CI / Frontend a11y check (push) Successful in 2m7s
CI / Go vet (dev) (push) Successful in 1m58s
CI / go mod tidy (push) Successful in 35s
CI / Frontend QC (audit) (push) Successful in 39s
CI / Staticcheck (prod) (push) Successful in 2m44s
CI / Go vulnerabilities (push) Successful in 1m46s
CI / Staticcheck (dev) (push) Successful in 3m45s
CI / golangci-lint (push) Successful in 3m47s
CI / Frontend QC (typecheck) (push) Successful in 1m43s
CI / Security scan (dev) (push) Successful in 4m8s
CI / Security scan (prod) (push) Successful in 3m51s
CI / Frontend QC (lint) (push) Successful in 1m53s
CI / Svelte strict check (push) Successful in 58s
CI / Tests (prod) (push) Successful in 3m15s
CI / Tests (dev) (push) Successful in 3m39s
CI / Race (prod) (push) Successful in 6m50s
CI / Race (dev) (push) Successful in 7m6s
2026-07-11 17:10:11 +01:00
popertots 0afa642a10 fix: add 60% coverage minimum to CI, scope prettier to staged frontend files 2026-07-11 17:09:37 +01:00
popertotsandSisyphus d6a3e30503 fix: compare notification IDs instead of timestamps in upsert test
The PoolProxy.Begin routes to the outer test transaction, so PG NOW() returns the same value for both handler invocations. Comparing notification IDs correctly verifies the notification was deleted and recreated. Also removes unused testify/assert import.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-11 16:25:33 +01:00
popertots c8051a76d6 fix: replace time.Sleep with poll loops in tests, fix a11y target=_blank violations
CI / Env docs check (push) Successful in 16s
CI / Nginx config check (push) Successful in 22s
CI / Docker compose check (push) Successful in 23s
CI / Frontend major deps (push) Successful in 23s
CI / Frontend deps check (push) Successful in 28s
CI / Secrets scan (push) Successful in 36s
CI / Go build (push) Successful in 37s
CI / Frontend build (push) Successful in 43s
CI / Knip (push) Successful in 52s
CI / Frontend a11y check (push) Successful in 1m48s
CI / Go vet (prod) (push) Successful in 1m36s
CI / Go vet (dev) (push) Successful in 2m11s
CI / go mod tidy (push) Successful in 1m0s
CI / Frontend QC (audit) (push) Successful in 35s
CI / Staticcheck (prod) (push) Successful in 2m47s
CI / Staticcheck (dev) (push) Successful in 3m4s
CI / golangci-lint (push) Successful in 3m24s
CI / Go vulnerabilities (push) Successful in 1m52s
CI / Frontend QC (lint) (push) Failing after 1m2s
CI / Frontend QC (typecheck) (push) Successful in 1m23s
CI / Svelte strict check (push) Has been skipped
CI / Security scan (prod) (push) Successful in 4m15s
CI / Security scan (dev) (push) Successful in 4m54s
CI / Tests (prod) (push) Successful in 3m48s
CI / Tests (dev) (push) Failing after 4m2s
CI / Race (prod) (push) Failing after 7m15s
CI / Race (dev) (push) Failing after 7m20s
2026-07-11 16:16:23 +01:00
popertots 0c1fc2b819 fix: log internal errors server-side, add timeout to GDPR goroutine 2026-07-11 16:09:11 +01:00
popertots 05c5d73d30 fix: add ShouldFail to Square MockClient for testing payment error paths 2026-07-11 16:07:05 +01:00
popertots ce0bb43ebf fix: auth and ratelimit middleware return JSON errors instead of text/plain 2026-07-11 16:05:56 +01:00
popertots e4a56ab04d fix: add defer tx.Rollback to CreateTipPayment to prevent transaction leak 2026-07-11 16:04:48 +01:00
popertotsandSisyphus a3243fab27 fix: auto-set DAV_SKIP_INIT=1 in test init to match local GO_TESTING behavior
The DAV_SKIP_INIT env var was only set in CI, not locally. db_test_init.go always auto-sets GO_TESTING=1 for local runs — now does the same for DAV_SKIP_INIT, so tests don't panic on DAV init failure.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-07-11 15:13:51 +01:00
popertots 4d87bf791f fix: replace GO_TESTING with DAV_SKIP_INIT for DAV service initialization
CI / Env docs check (push) Failing after 17s
CI / Docker compose check (push) Successful in 1m29s
CI / Secrets scan (push) Successful in 1m33s
CI / Frontend major deps (push) Successful in 1m31s
CI / Go build (push) Successful in 1m33s
CI / Frontend deps check (push) Successful in 1m33s
CI / Frontend build (push) Successful in 1m32s
CI / Nginx config check (push) Successful in 1m33s
CI / go mod tidy (push) Successful in 1m18s
CI / Go vulnerabilities (push) Failing after 0s
CI / Knip (push) Failing after 0s
CI / Frontend a11y check (push) Failing after 0s
CI / Svelte strict check (push) Has been skipped
CI / Frontend QC (audit) (push) Has been skipped
CI / Frontend QC (typecheck) (push) Has been skipped
CI / Frontend QC (lint) (push) Has been skipped
CI / Go vet (prod) (push) Successful in 1m31s
CI / Go vet (dev) (push) Successful in 1m51s
CI / Staticcheck (prod) (push) Successful in 2m27s
CI / Staticcheck (dev) (push) Successful in 2m55s
CI / golangci-lint (push) Successful in 3m13s
CI / Security scan (prod) (push) Successful in 4m8s
CI / Security scan (dev) (push) Successful in 4m15s
CI / Tests (prod) (push) Has been skipped
CI / Tests (dev) (push) Has been skipped
CI / Race (prod) (push) Has been skipped
CI / Race (dev) (push) Has been skipped
2026-07-11 15:06:16 +01:00
popertots f147be0b99 fix: add error logging to remaining nolint:errcheck scan sites for observability
CI / Env docs check (push) Successful in 15s
CI / Docker compose check (push) Successful in 16s
CI / Nginx config check (push) Successful in 20s
CI / Frontend major deps (push) Successful in 30s
CI / Frontend deps check (push) Successful in 32s
CI / Secrets scan (push) Successful in 47s
CI / Go build (push) Successful in 44s
CI / Frontend build (push) Successful in 49s
CI / Go vet (dev) (push) Has been cancelled
CI / Go vet (prod) (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
CI / Staticcheck (dev) (push) Has been cancelled
CI / Staticcheck (prod) (push) Has been cancelled
CI / Security scan (dev) (push) Has been cancelled
CI / Security scan (prod) (push) Has been cancelled
CI / go mod tidy (push) Has been cancelled
CI / Tests (prod) (push) Has been cancelled
CI / Tests (dev) (push) Has been cancelled
CI / Race (prod) (push) Has been cancelled
CI / Race (dev) (push) Has been cancelled
CI / Go vulnerabilities (push) Has been cancelled
CI / Knip (push) Has been cancelled
CI / Frontend a11y check (push) Has been cancelled
CI / Svelte strict check (push) Has been cancelled
CI / Frontend QC (audit) (push) Has been cancelled
CI / Frontend QC (typecheck) (push) Has been cancelled
CI / Frontend QC (lint) (push) Has been cancelled
2026-07-11 15:04:53 +01:00
popertots ad15127777 fix: remove nonDepositPaymentType dead code, wire dead handlers to routes 2026-07-11 15:01:26 +01:00
popertots df325487cf fix: gift card admin notification uses NULL booking_id (not cardID), use tx not db.Conn
CI / Secrets scan (push) Failing after 26s
CI / Frontend major deps (push) Successful in 39s
CI / Nginx config check (push) Successful in 43s
CI / Docker compose check (push) Successful in 43s
CI / Env docs check (push) Successful in 46s
CI / Frontend deps check (push) Successful in 45s
CI / Go build (push) Successful in 54s
CI / Frontend build (push) Successful in 56s
CI / Knip (push) Successful in 1m42s
CI / Go vet (prod) (push) Successful in 1m49s
CI / Go vet (dev) (push) Successful in 1m50s
CI / Frontend a11y check (push) Successful in 2m5s
CI / go mod tidy (push) Successful in 31s
CI / Frontend QC (audit) (push) Successful in 51s
CI / Staticcheck (prod) (push) Successful in 3m15s
CI / Go vulnerabilities (push) Successful in 1m41s
CI / Staticcheck (dev) (push) Successful in 3m41s
CI / Frontend QC (typecheck) (push) Successful in 1m34s
CI / golangci-lint (push) Has been cancelled
CI / Security scan (dev) (push) Has been cancelled
CI / Security scan (prod) (push) Has been cancelled
CI / Tests (prod) (push) Has been cancelled
CI / Tests (dev) (push) Has been cancelled
CI / Race (prod) (push) Has been cancelled
CI / Race (dev) (push) Has been cancelled
CI / Svelte strict check (push) Has been cancelled
CI / Frontend QC (lint) (push) Has been cancelled
2026-07-11 14:59:09 +01:00
popertots ac104e19c5 fix: remove rate limiter dev stub, consolidate tests under all build tags
CI / Docker compose check (push) Successful in 13s
CI / Env docs check (push) Successful in 14s
CI / Nginx config check (push) Successful in 15s
CI / Frontend major deps (push) Successful in 25s
CI / Frontend deps check (push) Successful in 26s
CI / Secrets scan (push) Successful in 35s
CI / Go build (push) Successful in 42s
CI / Frontend build (push) Successful in 45s
CI / Knip (push) Successful in 23s
CI / Frontend a11y check (push) Successful in 1m13s
CI / go mod tidy (push) Successful in 37s
CI / Go vet (prod) (push) Successful in 2m5s
CI / Go vet (dev) (push) Successful in 2m16s
CI / Frontend QC (audit) (push) Successful in 45s
CI / Go vulnerabilities (push) Successful in 1m29s
CI / Staticcheck (prod) (push) Successful in 3m3s
CI / Staticcheck (dev) (push) Successful in 3m46s
CI / Frontend QC (typecheck) (push) Successful in 2m1s
CI / golangci-lint (push) Successful in 4m19s
CI / Security scan (prod) (push) Successful in 4m23s
CI / Security scan (dev) (push) Successful in 4m35s
CI / Frontend QC (lint) (push) Successful in 1m51s
CI / Svelte strict check (push) Successful in 1m21s
CI / Tests (prod) (push) Successful in 3m39s
CI / Tests (dev) (push) Failing after 3m50s
CI / Race (prod) (push) Successful in 7m4s
CI / Race (dev) (push) Failing after 7m12s
2026-07-11 14:41:58 +01:00
popertots 9b235a1298 fix: add error logging to 3 non-aggregate nolint:errcheck sites (duration lookup, deposit-paid scans) 2026-07-11 14:41:06 +01:00
popertots d410dce0e0 fix: gift card friend purchase notifies admin, frontend no longer falsely claims email sent 2026-07-11 14:39:54 +01:00
popertots 9f9f0eed98 fix: add error logging to discount campaign payment/times_redeemed execs 2026-07-11 14:37:47 +01:00
popertots 7a51bcc49a fix: JTI revocation returns error, LogoutHandler returns 500 on failure 2026-07-11 14:35:34 +01:00
popertots b549014a68 fix: add nolint:errcheck to AdminGetInProgressBookingHandler json.Encode
CI / Docker compose check (push) Successful in 21s
CI / Env docs check (push) Successful in 23s
CI / Nginx config check (push) Successful in 27s
CI / Frontend deps check (push) Successful in 30s
CI / Frontend major deps (push) Successful in 30s
CI / Go build (push) Successful in 38s
CI / Secrets scan (push) Successful in 43s
CI / Frontend build (push) Successful in 46s
CI / Knip (push) Successful in 1m10s
CI / Go vet (prod) (push) Successful in 1m21s
CI / Go vet (dev) (push) Successful in 1m53s
CI / Frontend a11y check (push) Successful in 2m16s
CI / go mod tidy (push) Successful in 50s
CI / Staticcheck (dev) (push) Successful in 2m48s
CI / Frontend QC (audit) (push) Successful in 59s
CI / golangci-lint (push) Successful in 3m13s
CI / Go vulnerabilities (push) Successful in 1m35s
CI / Staticcheck (prod) (push) Successful in 3m28s
CI / Frontend QC (typecheck) (push) Successful in 1m32s
CI / Security scan (prod) (push) Successful in 3m49s
CI / Security scan (dev) (push) Successful in 4m45s
CI / Frontend QC (lint) (push) Successful in 2m8s
CI / Svelte strict check (push) Successful in 1m16s
CI / Tests (prod) (push) Successful in 3m2s
CI / Tests (dev) (push) Successful in 3m3s
CI / Race (prod) (push) Successful in 7m3s
CI / Race (dev) (push) Successful in 7m15s
2026-07-11 13:30:09 +01:00
popertots 28620f69a5 fix: restore dead functions properly, match test expectations, fix vet/lint
CI / Docker compose check (push) Successful in 13s
CI / Env docs check (push) Successful in 14s
CI / Nginx config check (push) Successful in 14s
CI / Frontend major deps (push) Successful in 25s
CI / Frontend deps check (push) Successful in 25s
CI / Secrets scan (push) Successful in 39s
CI / Go build (push) Successful in 39s
CI / Frontend build (push) Successful in 45s
CI / Knip (push) Successful in 27s
CI / Frontend a11y check (push) Successful in 1m27s
CI / Go vet (prod) (push) Successful in 1m53s
CI / go mod tidy (push) Successful in 43s
CI / Go vet (dev) (push) Successful in 2m6s
CI / Frontend QC (audit) (push) Successful in 45s
CI / Staticcheck (prod) (push) Successful in 2m51s
CI / Staticcheck (dev) (push) Successful in 3m5s
CI / Frontend QC (typecheck) (push) Successful in 1m50s
CI / Go vulnerabilities (push) Successful in 2m8s
CI / golangci-lint (push) Failing after 4m3s
CI / Security scan (prod) (push) Successful in 4m35s
CI / Security scan (dev) (push) Successful in 4m47s
CI / Tests (prod) (push) Has been skipped
CI / Tests (dev) (push) Has been skipped
CI / Race (prod) (push) Has been skipped
CI / Race (dev) (push) Has been skipped
CI / Frontend QC (lint) (push) Successful in 2m8s
CI / Svelte strict check (push) Successful in 38s
2026-07-11 13:23:27 +01:00
popertots a3c0be2890 fix: audit nolint:errcheck — fix dangerous suppression patterns
CI / Nginx config check (push) Successful in 14s
CI / Docker compose check (push) Successful in 14s
CI / Env docs check (push) Successful in 15s
CI / Frontend major deps (push) Successful in 25s
CI / Frontend deps check (push) Successful in 26s
CI / Secrets scan (push) Successful in 36s
CI / Go build (push) Successful in 42s
CI / Frontend build (push) Successful in 48s
CI / Knip (push) Successful in 28s
CI / Frontend a11y check (push) Successful in 1m26s
CI / Go vet (prod) (push) Failing after 2m9s
CI / go mod tidy (push) Successful in 59s
CI / Go vet (dev) (push) Failing after 2m10s
CI / Staticcheck (prod) (push) Failing after 2m42s
CI / Staticcheck (dev) (push) Failing after 2m56s
CI / Frontend QC (audit) (push) Successful in 1m7s
CI / golangci-lint (push) Successful in 3m38s
CI / Go vulnerabilities (push) Successful in 1m40s
CI / Frontend QC (typecheck) (push) Successful in 1m45s
CI / Frontend QC (lint) (push) Failing after 1m21s
CI / Svelte strict check (push) Has been skipped
CI / Security scan (prod) (push) Successful in 4m18s
CI / Security scan (dev) (push) Successful in 4m28s
CI / Tests (prod) (push) Has been skipped
CI / Tests (dev) (push) Has been skipped
CI / Race (prod) (push) Has been skipped
CI / Race (dev) (push) Has been skipped
2026-07-11 12:57:41 +01:00
popertots 19be37171b fix: remove 3 dead code blocks (UserCancelBookingHandler, AdminGetInProgressBookingHandler, processImage) 2026-07-11 12:51:42 +01:00
popertots 844df4c127 fix: use raw clock.Now()+40h for booking test times (avoids time-sensitive boundaries)
CI / Nginx config check (push) Successful in 24s
CI / Docker compose check (push) Successful in 25s
CI / Env docs check (push) Successful in 28s
CI / Frontend deps check (push) Successful in 44s
CI / Frontend major deps (push) Failing after 44s
CI / Secrets scan (push) Successful in 49s
CI / Go build (push) Successful in 53s
CI / Frontend build (push) Successful in 55s
CI / Knip (push) Successful in 41s
CI / Frontend a11y check (push) Successful in 2m14s
CI / Go vet (prod) (push) Successful in 2m3s
CI / Go vet (dev) (push) Successful in 2m5s
CI / go mod tidy (push) Successful in 32s
CI / Frontend QC (audit) (push) Successful in 41s
CI / Staticcheck (dev) (push) Successful in 2m56s
CI / Staticcheck (prod) (push) Successful in 3m2s
CI / golangci-lint (push) Successful in 3m16s
CI / Go vulnerabilities (push) Successful in 1m21s
CI / Frontend QC (typecheck) (push) Successful in 1m29s
CI / Security scan (prod) (push) Successful in 4m16s
CI / Security scan (dev) (push) Successful in 4m46s
CI / Frontend QC (lint) (push) Successful in 2m4s
CI / Svelte strict check (push) Successful in 1m51s
CI / Tests (prod) (push) Successful in 3m54s
CI / Tests (dev) (push) Failing after 3m59s
CI / Race (prod) (push) Successful in 7m14s
CI / Race (dev) (push) Successful in 7m25s
2026-07-11 10:35:59 +01:00
popertots abd53baf35 fix: time-sensitive tests use savepoint pattern, avoid 48h auto-approval boundary
CI / Env docs check (push) Successful in 17s
CI / Docker compose check (push) Successful in 19s
CI / Nginx config check (push) Successful in 20s
CI / Frontend deps check (push) Successful in 27s
CI / Frontend major deps (push) Failing after 27s
CI / Secrets scan (push) Successful in 39s
CI / Go build (push) Successful in 40s
CI / Frontend build (push) Successful in 43s
CI / Knip (push) Successful in 41s
CI / Frontend a11y check (push) Successful in 1m37s
CI / Go vet (prod) (push) Successful in 1m53s
CI / go mod tidy (push) Successful in 31s
CI / Frontend QC (audit) (push) Successful in 51s
CI / Go vet (dev) (push) Successful in 2m50s
CI / Staticcheck (prod) (push) Successful in 2m57s
CI / Staticcheck (dev) (push) Successful in 3m19s
CI / Go vulnerabilities (push) Successful in 1m35s
CI / golangci-lint (push) Successful in 3m37s
CI / Frontend QC (typecheck) (push) Successful in 1m35s
CI / Security scan (prod) (push) Successful in 4m10s
CI / Security scan (dev) (push) Successful in 4m38s
CI / Frontend QC (lint) (push) Successful in 1m58s
CI / Svelte strict check (push) Successful in 1m12s
CI / Tests (prod) (push) Successful in 3m8s
CI / Tests (dev) (push) Failing after 4m8s
CI / Race (prod) (push) Successful in 7m34s
CI / Race (dev) (push) Failing after 7m40s
2026-07-11 10:14:12 +01:00
popertots ae2acc45c3 chore: bump eslint 9.39.4 -> 9.39.5
CI / Env docs check (push) Successful in 1m46s
CI / Docker compose check (push) Successful in 51s
CI / Nginx config check (push) Successful in 55s
CI / Frontend deps check (push) Successful in 1m52s
CI / Frontend major deps (push) Failing after 1m6s
CI / Go build (push) Successful in 2m14s
CI / Frontend build (push) Successful in 1m29s
CI / Secrets scan (push) Successful in 2m26s
CI / Knip (push) Successful in 1m4s
CI / Frontend a11y check (push) Successful in 2m18s
CI / Go vet (prod) (push) Successful in 1m51s
CI / Go vet (dev) (push) Successful in 2m11s
CI / go mod tidy (push) Successful in 40s
CI / Staticcheck (prod) (push) Successful in 2m43s
CI / Frontend QC (audit) (push) Successful in 58s
CI / Go vulnerabilities (push) Successful in 1m27s
CI / Staticcheck (dev) (push) Successful in 3m20s
CI / golangci-lint (push) Successful in 3m30s
CI / Frontend QC (typecheck) (push) Successful in 1m26s
CI / Frontend QC (lint) (push) Successful in 1m54s
CI / Security scan (dev) (push) Successful in 4m38s
CI / Security scan (prod) (push) Successful in 4m2s
CI / Svelte strict check (push) Successful in 57s
CI / Tests (prod) (push) Failing after 3m55s
CI / Tests (dev) (push) Failing after 4m9s
CI / Race (prod) (push) Failing after 7m35s
CI / Race (dev) (push) Failing after 7m44s
2026-07-11 00:31:40 +01:00
popertots de37b07233 fix: use savepoint pattern for today test (matches other tests in file)
CI / Docker compose check (push) Successful in 16s
CI / Env docs check (push) Successful in 18s
CI / Nginx config check (push) Successful in 17s
CI / Frontend deps check (push) Failing after 28s
CI / Frontend major deps (push) Failing after 28s
CI / Knip (push) Has been skipped
CI / Frontend a11y check (push) Has been skipped
CI / Secrets scan (push) Successful in 41s
CI / Go build (push) Successful in 41s
CI / Frontend build (push) Successful in 45s
CI / Svelte strict check (push) Has been skipped
CI / Frontend QC (audit) (push) Has been skipped
CI / Frontend QC (typecheck) (push) Has been skipped
CI / Frontend QC (lint) (push) Has been skipped
CI / go mod tidy (push) Successful in 18s
CI / Go vet (prod) (push) Successful in 1m46s
CI / Go vulnerabilities (push) Successful in 2m2s
CI / Go vet (dev) (push) Successful in 2m22s
CI / Staticcheck (prod) (push) Successful in 2m31s
CI / Staticcheck (dev) (push) Successful in 3m29s
CI / golangci-lint (push) Successful in 3m38s
CI / Security scan (prod) (push) Successful in 4m5s
CI / Security scan (dev) (push) Successful in 4m6s
CI / Tests (prod) (push) Has been cancelled
CI / Tests (dev) (push) Has been cancelled
CI / Race (prod) (push) Has been cancelled
CI / Race (dev) (push) Has been cancelled
2026-07-11 00:26:14 +01:00
popertots fe47cb486a fix: replace 3.5s sleep with poll loop in till checkout test
CI / Docker compose check (push) Successful in 51s
CI / Env docs check (push) Successful in 55s
CI / Frontend major deps (push) Failing after 55s
CI / Secrets scan (push) Successful in 58s
CI / Frontend deps check (push) Successful in 57s
CI / Frontend build (push) Successful in 55s
CI / Go build (push) Successful in 57s
CI / Nginx config check (push) Successful in 56s
CI / go mod tidy (push) Successful in 20s
CI / Go vet (prod) (push) Successful in 2m17s
CI / Go vulnerabilities (push) Successful in 1m56s
CI / Go vet (dev) (push) Successful in 2m21s
CI / Staticcheck (prod) (push) Successful in 2m57s
CI / Frontend a11y check (push) Failing after 57s
CI / Staticcheck (dev) (push) Successful in 3m16s
CI / Knip (push) Successful in 1m7s
CI / golangci-lint (push) Successful in 3m36s
CI / Frontend QC (audit) (push) Successful in 1m8s
CI / Security scan (prod) (push) Successful in 4m37s
CI / Security scan (dev) (push) Successful in 4m43s
CI / Frontend QC (typecheck) (push) Successful in 1m20s
CI / Frontend QC (lint) (push) Successful in 1m37s
CI / Svelte strict check (push) Successful in 2m18s
CI / Tests (prod) (push) Successful in 3m25s
CI / Tests (dev) (push) Failing after 3m32s
CI / Race (prod) (push) Successful in 7m11s
CI / Race (dev) (push) Successful in 7m25s
2026-07-10 20:53:42 +01:00
popertots b91339ec56 fix: use targeted DELETE in DAV test instead of full table wipe 2026-07-10 20:53:04 +01:00
popertots 50ce98d729 fix: remove dead GenerateRefreshToken calls (tokens never consumed) 2026-07-10 20:52:47 +01:00
popertots a4a80246d1 fix: restore S3 error stubs, add CI timeouts, gofmt handlers.go, fix comment
CI / Env docs check (push) Successful in 14s
CI / Docker compose check (push) Successful in 20s
CI / Nginx config check (push) Successful in 20s
CI / Frontend major deps (push) Failing after 30s
CI / Frontend deps check (push) Successful in 31s
CI / Secrets scan (push) Successful in 38s
CI / Go build (push) Successful in 38s
CI / Frontend build (push) Successful in 42s
CI / Knip (push) Successful in 40s
CI / Frontend a11y check (push) Successful in 2m2s
CI / Go vet (prod) (push) Successful in 1m56s
CI / Go vet (dev) (push) Successful in 2m7s
CI / Staticcheck (prod) (push) Successful in 2m51s
CI / Staticcheck (dev) (push) Successful in 3m3s
CI / go mod tidy (push) Successful in 1m17s
CI / Frontend QC (audit) (push) Successful in 1m34s
CI / golangci-lint (push) Successful in 3m44s
CI / Go vulnerabilities (push) Successful in 2m10s
CI / Frontend QC (typecheck) (push) Successful in 1m29s
CI / Security scan (prod) (push) Successful in 4m3s
CI / Security scan (dev) (push) Successful in 4m37s
CI / Frontend QC (lint) (push) Successful in 1m40s
CI / Svelte strict check (push) Successful in 1m22s
CI / Tests (prod) (push) Successful in 3m12s
CI / Tests (dev) (push) Successful in 3m32s
CI / Race (prod) (push) Successful in 7m12s
CI / Race (dev) (push) Successful in 7m22s
- s3.go: restore error returns on prod Upload/Download/Delete stubs
  (silent nil was dangerous — callers would think writes succeeded)
- CI: add -timeout 300s to tests, -timeout 480s to race, GO_TESTING to race env
- handlers.go: gofmt indentation fix for GetCheckoutStatus struct literal
- validators.go: fix comment to include A-F (matched the regex)
2026-07-10 20:39:17 +01:00
popertots 609a099677 fix: data races in Square mock and scheduler hostname tests
CI / Env docs check (push) Successful in 12s
CI / Docker compose check (push) Successful in 14s
CI / Nginx config check (push) Successful in 17s
CI / Frontend major deps (push) Failing after 23s
CI / Frontend deps check (push) Successful in 28s
CI / Secrets scan (push) Successful in 37s
CI / Go build (push) Successful in 37s
CI / Frontend build (push) Successful in 1m6s
CI / Knip (push) Successful in 34s
CI / Frontend a11y check (push) Successful in 1m36s
CI / Go vet (prod) (push) Successful in 1m30s
CI / go mod tidy (push) Successful in 44s
CI / Go vet (dev) (push) Successful in 2m9s
CI / Frontend QC (audit) (push) Successful in 45s
CI / Go vulnerabilities (push) Successful in 1m24s
CI / Staticcheck (prod) (push) Successful in 2m55s
CI / Staticcheck (dev) (push) Successful in 3m28s
CI / golangci-lint (push) Successful in 3m29s
CI / Frontend QC (typecheck) (push) Successful in 1m26s
CI / Security scan (prod) (push) Successful in 4m22s
CI / Security scan (dev) (push) Successful in 4m23s
CI / Frontend QC (lint) (push) Successful in 1m58s
CI / Svelte strict check (push) Successful in 57s
CI / Tests (prod) (push) Successful in 4m15s
CI / Tests (dev) (push) Successful in 4m17s
CI / Race (prod) (push) Successful in 8m2s
CI / Race (dev) (push) Successful in 8m17s
- square_dev.go: return a copy of CheckoutResult to the caller
  instead of sharing the map-stored pointer, preventing the goroutine
  from racing with the caller on Status field reads
- scheduler_test.go: remove t.Parallel from TestInitHostname_* tests
  which modify a shared package-level hostname variable
2026-07-10 19:10:31 +01:00
popertots 2cd35ea84a fix: S3-dependent tests skip in prod, add GO_TESTING to CI for dav init
CI / Env docs check (push) Successful in 15s
CI / Nginx config check (push) Successful in 21s
CI / Docker compose check (push) Successful in 22s
CI / Frontend deps check (push) Successful in 22s
CI / Frontend major deps (push) Failing after 40s
CI / Secrets scan (push) Successful in 44s
CI / Go build (push) Successful in 45s
CI / Frontend build (push) Successful in 1m8s
CI / Knip (push) Successful in 41s
CI / Frontend a11y check (push) Successful in 1m20s
CI / go mod tidy (push) Successful in 35s
CI / Go vet (prod) (push) Successful in 2m35s
CI / Go vet (dev) (push) Successful in 2m36s
CI / Go vulnerabilities (push) Successful in 1m27s
CI / Staticcheck (prod) (push) Successful in 3m13s
CI / Frontend QC (audit) (push) Successful in 50s
CI / Staticcheck (dev) (push) Successful in 3m31s
CI / golangci-lint (push) Successful in 4m0s
CI / Frontend QC (typecheck) (push) Successful in 1m35s
CI / Security scan (prod) (push) Successful in 4m28s
CI / Security scan (dev) (push) Successful in 4m33s
CI / Frontend QC (lint) (push) Successful in 1m59s
CI / Svelte strict check (push) Successful in 1m5s
CI / Tests (prod) (push) Successful in 4m8s
CI / Tests (dev) (push) Successful in 4m13s
CI / Race (prod) (push) Successful in 8m3s
CI / Race (dev) (push) Failing after 8m14s
2026-07-10 18:45:18 +01:00
popertots cbaed41056 fix: restrict user_coverage_test build to test && dev
CI / Env docs check (push) Successful in 45s
CI / Frontend deps check (push) Successful in 45s
CI / Secrets scan (push) Successful in 49s
CI / Frontend major deps (push) Failing after 46s
CI / Go build (push) Successful in 47s
CI / Nginx config check (push) Successful in 44s
CI / Docker compose check (push) Successful in 46s
CI / Frontend build (push) Successful in 1m22s
CI / Knip (push) Successful in 46s
CI / Go vet (prod) (push) Successful in 1m32s
CI / Frontend a11y check (push) Successful in 2m0s
CI / Go vet (dev) (push) Successful in 2m1s
CI / go mod tidy (push) Successful in 34s
CI / Frontend QC (audit) (push) Successful in 39s
CI / Staticcheck (prod) (push) Successful in 2m51s
CI / Staticcheck (dev) (push) Successful in 3m57s
CI / Frontend QC (typecheck) (push) Successful in 1m51s
CI / Go vulnerabilities (push) Successful in 1m58s
CI / golangci-lint (push) Successful in 4m1s
CI / Security scan (prod) (push) Successful in 3m53s
CI / Frontend QC (lint) (push) Successful in 2m5s
CI / Security scan (dev) (push) Successful in 4m12s
CI / Svelte strict check (push) Successful in 1m18s
CI / Tests (prod) (push) Failing after 2m59s
CI / Tests (dev) (push) Successful in 3m33s
CI / Race (prod) (push) Failing after 7m40s
CI / Race (dev) (push) Failing after 8m0s
2026-07-10 18:24:39 +01:00
popertots 3029fd5179 test: add coverage tests across backend + fix mock for PENDING checkout support
CI / Nginx config check (push) Successful in 13s
CI / Env docs check (push) Successful in 15s
CI / Docker compose check (push) Successful in 15s
CI / Frontend major deps (push) Failing after 24s
CI / Frontend deps check (push) Successful in 30s
CI / Secrets scan (push) Successful in 38s
CI / Go build (push) Successful in 39s
CI / Frontend build (push) Successful in 1m3s
CI / Knip (push) Successful in 45s
CI / Go vet (prod) (push) Failing after 1m42s
CI / Frontend a11y check (push) Successful in 2m34s
CI / Go vet (dev) (push) Successful in 2m29s
CI / Staticcheck (prod) (push) Failing after 2m38s
CI / go mod tidy (push) Successful in 1m3s
CI / Staticcheck (dev) (push) Successful in 2m55s
CI / Frontend QC (audit) (push) Successful in 51s
CI / golangci-lint (push) Successful in 3m22s
CI / Go vulnerabilities (push) Successful in 1m26s
CI / Frontend QC (typecheck) (push) Successful in 2m18s
CI / Security scan (prod) (push) Successful in 4m18s
CI / Security scan (dev) (push) Successful in 4m40s
CI / Tests (prod) (push) Has been skipped
CI / Tests (dev) (push) Has been skipped
CI / Race (prod) (push) Has been skipped
CI / Race (dev) (push) Has been skipped
CI / Frontend QC (lint) (push) Successful in 2m18s
CI / Svelte strict check (push) Successful in 43s
New test files cover previously untested paths across DAV, validators,
S3, Square, mw, bookings, user, and payments packages.

Includes mock fix: HoldCheckouts flag on MockClient allows tests to
pause auto-complete goroutine for testing PENDING checkout states.

Coverage: 50.4% → 65.0% (+14.6pp)
2026-07-10 18:13:44 +01:00
popertots 990c86495c fix: suppress unused nonDepositPaymentType in prod-staticcheck
CI / Docker compose check (push) Successful in 1m6s
CI / Env docs check (push) Successful in 1m6s
CI / Frontend deps check (push) Successful in 1m9s
CI / Frontend major deps (push) Failing after 1m9s
CI / Secrets scan (push) Successful in 1m9s
CI / Go build (push) Successful in 1m10s
CI / Frontend build (push) Successful in 1m10s
CI / Nginx config check (push) Successful in 1m12s
CI / Knip (push) Successful in 25s
CI / Go vet (prod) (push) Successful in 2m1s
CI / Frontend a11y check (push) Successful in 2m13s
CI / Go vet (dev) (push) Successful in 2m20s
CI / go mod tidy (push) Successful in 1m18s
CI / Staticcheck (prod) (push) Successful in 3m23s
CI / Staticcheck (dev) (push) Successful in 3m25s
CI / golangci-lint (push) Successful in 3m51s
CI / Frontend QC (audit) (push) Successful in 2m9s
CI / Security scan (prod) (push) Successful in 4m5s
CI / Security scan (dev) (push) Successful in 4m31s
CI / Go vulnerabilities (push) Successful in 2m22s
CI / Frontend QC (lint) (push) Failing after 1m11s
CI / Frontend QC (typecheck) (push) Successful in 1m21s
CI / Svelte strict check (push) Has been skipped
CI / Tests (prod) (push) Successful in 1m52s
CI / Tests (dev) (push) Failing after 2m12s
CI / Race (prod) (push) Successful in 3m31s
CI / Race (dev) (push) Successful in 5m0s
2026-07-10 13:00:33 +01:00
popertots 3d337b61b8 fix: remove t.Parallel from VAT tests to eliminate deadlock flakiness
CI / Nginx config check (push) Successful in 10s
CI / Docker compose check (push) Successful in 11s
CI / Env docs check (push) Successful in 11s
CI / Frontend major deps (push) Failing after 25s
CI / Frontend deps check (push) Successful in 26s
CI / Secrets scan (push) Successful in 40s
CI / Go build (push) Successful in 40s
CI / Frontend build (push) Successful in 1m8s
CI / Knip (push) Successful in 38s
CI / Go vet (prod) (push) Successful in 1m51s
CI / Frontend a11y check (push) Failing after 2m3s
CI / Go vet (dev) (push) Successful in 2m1s
CI / go mod tidy (push) Successful in 1m24s
CI / Staticcheck (prod) (push) Failing after 3m19s
CI / Staticcheck (dev) (push) Successful in 3m20s
CI / golangci-lint (push) Successful in 3m22s
CI / Go vulnerabilities (push) Successful in 1m30s
CI / Frontend QC (audit) (push) Successful in 2m14s
CI / Frontend QC (lint) (push) Failing after 1m5s
CI / Frontend QC (typecheck) (push) Successful in 1m16s
CI / Security scan (dev) (push) Failing after 4m7s
CI / Security scan (prod) (push) Failing after 4m4s
CI / Tests (prod) (push) Has been skipped
CI / Tests (dev) (push) Has been skipped
CI / Race (prod) (push) Has been skipped
CI / Race (dev) (push) Has been skipped
CI / Svelte strict check (push) Has been skipped
2026-07-10 12:49:57 +01:00